Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 11791016: Magnifier: support guest mode (Closed)

Created:
7 years, 11 months ago by yoshiki
Modified:
7 years, 11 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, zork+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Magnifier: support guest mode On guest mode, NOTIFICATION_SESSION_STARTED event is not fired. We use NOTIFICATION_PROFILE_CREATED instead. BUG=167156 TEST=manual R=zork@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175813

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
zork: could you take a look?
7 years, 11 months ago (2013-01-07 07:08:03 UTC) #1
Zachary Kuznia
lgtm
7 years, 11 months ago (2013-01-09 08:16:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11791016/5001
7 years, 11 months ago (2013-01-09 08:18:25 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) content_browsertests
7 years, 11 months ago (2013-01-09 11:36:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11791016/5001
7 years, 11 months ago (2013-01-09 13:54:30 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 16:48:19 UTC) #6
Message was sent while issue was closed.
Change committed as 175813

Powered by Google App Engine
This is Rietveld 408576698