Issue 11791009: IPC implementation for create/delete ObjectStore/Index

Issue 11791009: IPC implementation for create/delete ObjectStore/Index (Closed)

Created:
7 years, 11 months ago by alecflett

Modified:
7 years, 11 months ago

Reviewers:
Tom Sepez, dgrogan, jsbell

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

IPC implementation for create/delete ObjectStore/Index R=jsbell,dgrogan,Tom Sepez BUG=161958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175703

Patch Set 2 : Add HostTransactionId where appropriate #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+251 lines, -20 lines)			Patch
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.h	View		3 chunks	+19 lines, -5 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.cc	View	1	6 chunks	+83 lines, -5 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_messages.h	View	1	5 chunks	+64 lines, -6 lines	0 comments	Download
M	content/common/indexed_db/proxy_webidbdatabase_impl.h	View		2 chunks	+19 lines, -1 line	0 comments	Download
M	content/common/indexed_db/proxy_webidbdatabase_impl.cc	View		3 chunks	+66 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alecflett

jsbell/tsepez - quick review? mostly boilerplate here. its depending on https://bugs.webkit.org/show_bug.cgi?id=106148 and https://bugs.webkit.org/show_bug.cgi?id=106117 to land, ...

7 years, 11 months ago (2013-01-05 01:20:15 UTC) #1

jsbell

lgtm *except* for uncertainty around HostTransactionId https://codereview.chromium.org/11791009/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): https://codereview.chromium.org/11791009/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc#newcode462 content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:462: params.transaction_id, Doesn't this ...

7 years, 11 months ago (2013-01-08 18:44:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11791009/7001

7 years, 11 months ago (2013-01-08 22:08:30 UTC) #4

Message was sent while issue was closed.

Change committed as 175703

Expand Messages | Collapse Messages