Rearrange gyp files for Message Center

Rearrange gyp files for Message Center

In order to facilitate the move to MessageCenterNotificationManager, we
need to be able to determine when message_center.gyp is being included
in the build.  This change defines ENABLE_MESSAGE_CENTER which can be
used for conditional compilation.

r=stevenjb@chromium.org
TBR=ben@chromium.org

BUG=168605
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175876

[dewittj, 2013-01-05 00:50:52]

This marks the message center specific code better and will allow us to expand
the platforms on which the message center works more easily.

[stevenjb, 2013-01-07 23:08:05]

I'm not particularly familiar with gyp, but lgtm w/ nit.

https://codereview.chromium.org/11791004/diff/5001/chrome/browser/notificatio...
File chrome/browser/notifications/notification_ui_manager.cc (right):

https://codereview.chromium.org/11791004/diff/5001/chrome/browser/notificatio...
chrome/browser/notifications/notification_ui_manager.cc:28: #if
defined(ENABLE_MESSAGE_CENTER)
This #if isn't really necessary since DelegatesToMessageCenter() will just
return false. (Less #if's is generally better)

[Ben Goodger (Google), 2013-01-08 21:01:58]

lgtm

[dewittj, 2013-01-08 23:50:01]

https://codereview.chromium.org/11791004/diff/5001/chrome/browser/notificatio...
File chrome/browser/notifications/notification_ui_manager.cc (right):

https://codereview.chromium.org/11791004/diff/5001/chrome/browser/notificatio...
chrome/browser/notifications/notification_ui_manager.cc:28: #if
defined(ENABLE_MESSAGE_CENTER)
On 2013/01/07 23:08:05, stevenjb (chromium) wrote:
> This #if isn't really necessary since DelegatesToMessageCenter() will just
> return false. (Less #if's is generally better)

This #if is required as the code is currently written, since
MessageCenterNotificationManager is undefined when ENABLE_MESSAGE_CENTER is
false.  Even if DelegatesToMessageCenter returns false, the #if'd code will fail
to compile.

[stevenjb, 2013-01-08 23:59:50]

https://codereview.chromium.org/11791004/diff/5001/chrome/browser/notificatio...
File chrome/browser/notifications/notification_ui_manager.cc (right):

https://codereview.chromium.org/11791004/diff/5001/chrome/browser/notificatio...
chrome/browser/notifications/notification_ui_manager.cc:28: #if
defined(ENABLE_MESSAGE_CENTER)
On 2013/01/08 23:50:01, dewittj wrote:
> On 2013/01/07 23:08:05, stevenjb (chromium) wrote:
> > This #if isn't really necessary since DelegatesToMessageCenter() will just
> > return false. (Less #if's is generally better)
> 
> This #if is required as the code is currently written, since
> MessageCenterNotificationManager is undefined when ENABLE_MESSAGE_CENTER is
> false.  Even if DelegatesToMessageCenter returns false, the #if'd code will
fail
> to compile.
Ah, of course, Duh.

[commit-bot: I haz the power, 2013-01-09 00:11:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/11791004/5001

[commit-bot: I haz the power, 2013-01-09 03:13:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-09 17:56:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/11791004/5001

[commit-bot: I haz the power, 2013-01-09 20:29:20]

Change committed as 175876