Change the behavior of --wallet-service-url.

Change the behavior of --wallet-service-url.
--wallet-service-url now specifies a prefix rather than a full path to autocheckout.
The default value is https://wallet.google.com/online/v2/ and the rest of each Wallet
URL will be appended to construct a working URL.
Also changed function prototypes to use the namespace in a more common way.
(namespace wallet {... vs wallet::)

BUG=168278
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175250

[Albert Bodenhamer, 2013-01-04 22:03:09]

Hey guys,

Can you take a quick look?  I broke these changes out of my sign in CL since
they seemed to stand better on their own.

Thanks.

[ahutter, 2013-01-04 22:10:18]

lgtm

[Ilya Sherman, 2013-01-04 22:11:46]

LGTM

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
File chrome/browser/autofill/wallet/wallet_service_url.cc (right):

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
chrome/browser/autofill/wallet/wallet_service_url.cc:16:
"https://wallet.google.com/online/v2/";
nit: Looks like this will now (juuust barely) fit on the previous line.

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
chrome/browser/autofill/wallet/wallet_service_url.cc:35: const char
wallet::kApiKey[] = "abcdefg";
nit: Remove the "wallet::" prefix?

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
chrome/browser/autofill/wallet/wallet_service_url.cc:39:
"wallet/autocheckout/getWalletItemsJwtless");
Optional nit: It seems a little repetitive to need to specify
wallet/autocheckout/ in so many places.  Maybe add a GetBaseAutocheckoutUrl()
function so that this is harder to accidentally typo or forget to update?

[commit-bot: I haz the power, 2013-01-04 22:36:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abodenha@chromium.org/11791003/8001

[Albert Bodenhamer, 2013-01-04 22:54:37]

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
File chrome/browser/autofill/wallet/wallet_service_url.cc (right):

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
chrome/browser/autofill/wallet/wallet_service_url.cc:16:
"https://wallet.google.com/online/v2/";
On 2013/01/04 22:11:46, Ilya Sherman wrote:
> nit: Looks like this will now (juuust barely) fit on the previous line.

Done.

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
chrome/browser/autofill/wallet/wallet_service_url.cc:35: const char
wallet::kApiKey[] = "abcdefg";
On 2013/01/04 22:11:46, Ilya Sherman wrote:
> nit: Remove the "wallet::" prefix?

Done.

https://codereview.chromium.org/11791003/diff/1/chrome/browser/autofill/walle...
chrome/browser/autofill/wallet/wallet_service_url.cc:39:
"wallet/autocheckout/getWalletItemsJwtless");
On 2013/01/04 22:11:46, Ilya Sherman wrote:
> Optional nit: It seems a little repetitive to need to specify
> wallet/autocheckout/ in so many places.  Maybe add a GetBaseAutocheckoutUrl()
> function so that this is harder to accidentally typo or forget to update?

Done.

[commit-bot: I haz the power, 2013-01-05 01:16:28]

Change committed as 175250