Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: webkit/glue/weburlloader_impl.cc

Issue 11790003: Always make an attempt to fill in the suggested filename. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/weburlloader_impl.cc
diff --git a/webkit/glue/weburlloader_impl.cc b/webkit/glue/weburlloader_impl.cc
index aed0318ecb2ba6057cbff5dcf0985e121a3c31ac..e1dd9ec10e5830b234c416b6c0009680ca64c929 100644
--- a/webkit/glue/weburlloader_impl.cc
+++ b/webkit/glue/weburlloader_impl.cc
@@ -246,10 +246,14 @@ void PopulateURLResponse(
// TODO(jungshik): Figure out the actual value of the referrer charset and
// pass it to GetSuggestedFilename.
std::string value;
- if (headers->EnumerateHeader(NULL, "content-disposition", &value)) {
- response->setSuggestedFileName(
- net::GetSuggestedFilename(url, value, "", "", "", std::string()));
- }
+ headers->EnumerateHeader(NULL, "content-disposition", &value);
+ response->setSuggestedFileName(
+ net::GetSuggestedFilename(url,
+ value,
+ std::string(), // referrer_charset
+ std::string(), // suggested_name
+ std::string(), // mime_type
+ std::string())); // default_name
Time time_val;
if (headers->GetLastModifiedValue(&time_val))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698