Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 11788026: Fixed flickering "Computing selection" label. (Closed)

Created:
7 years, 11 months ago by mtomasz
Modified:
7 years, 11 months ago
Reviewers:
dgozman, SeRya
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fixed flickering "Computing selection" label. In Files.app, while changing selection "computing selection..." label was shown too frequently causing flickering. This patch simplified the code by removing this redundant label. Along the way, the panel's contents disappearing has been fixed while changing selection very fast. TEST=Follow the bug description. BUG=167799 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177086

Patch Set 1 #

Patch Set 2 : Polished. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/selection.js View 1 2 chunks +0 lines, -5 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
mtomasz
@dgozman: PTAL.
7 years, 11 months ago (2013-01-08 04:57:19 UTC) #1
mtomasz
@SeRya: PTAL.
7 years, 11 months ago (2013-01-11 09:01:00 UTC) #2
SeRya
Bug suggest to leave prev state for 0.5 sec but CL apparently leaves it as ...
7 years, 11 months ago (2013-01-11 10:22:22 UTC) #3
mtomasz
https://codereview.chromium.org/11788026/diff/2001/chrome/browser/resources/file_manager/js/selection.js File chrome/browser/resources/file_manager/js/selection.js (left): https://codereview.chromium.org/11788026/diff/2001/chrome/browser/resources/file_manager/js/selection.js#oldcode214 chrome/browser/resources/file_manager/js/selection.js:214: var updateDelay = 200; On 2013/01/11 10:22:22, SeRya wrote: ...
7 years, 11 months ago (2013-01-15 01:41:07 UTC) #4
SeRya
lgtm
7 years, 11 months ago (2013-01-15 12:39:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11788026/2001
7 years, 11 months ago (2013-01-15 12:43:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests, content_browsertests, nacl_integration, sync_integration_tests
7 years, 11 months ago (2013-01-15 14:13:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11788026/2001
7 years, 11 months ago (2013-01-16 03:35:25 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 04:21:37 UTC) #9
Message was sent while issue was closed.
Change committed as 177086

Powered by Google App Engine
This is Rietveld 408576698