Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 11788002: Make the Windows sandbox support a normal x64 build (Closed)

Created:
7 years, 11 months ago by jschuh
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make the Windows sandbox support a normal x64 build I've fixed the dependencies, so we can now support building the sandbox and running the tests as part of a normal Win64 build. BUG=168414 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175278

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -26 lines) Patch
M sandbox/win/sandbox_win.gypi View 1 2 5 chunks +30 lines, -24 lines 0 comments Download
M sandbox/win/src/sandbox.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jschuh
Ignore the many lines. It's just a minor gyp change.
7 years, 11 months ago (2013-01-04 22:04:04 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 11 months ago (2013-01-04 22:09:51 UTC) #2
cpu_(ooo_6.6-7.5)
note that the bug referenced is marked a fixed, so please also add the other ...
7 years, 11 months ago (2013-01-04 22:10:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11788002/2003
7 years, 11 months ago (2013-01-04 22:28:38 UTC) #4
rvargas (doing something else)
LGTM! https://codereview.chromium.org/11788002/diff/4001/sandbox/win/sandbox_win.gypi File sandbox/win/sandbox_win.gypi (right): https://codereview.chromium.org/11788002/diff/4001/sandbox/win/sandbox_win.gypi#newcode140 sandbox/win/sandbox_win.gypi:140: 'src/interceptors_64.cc', Very nice!. Something we could consider for ...
7 years, 11 months ago (2013-01-04 22:39:42 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-04 22:56:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/11788002/6002
7 years, 11 months ago (2013-01-05 01:53:32 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 03:38:36 UTC) #8
Message was sent while issue was closed.
Change committed as 175278

Powered by Google App Engine
This is Rietveld 408576698