android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java - Issue 11787031: Fix hang in Android WebView release build tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

Issue 11787031: Fix hang in Android WebView release build tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Factor out check and add LOG(WARNING) when fails. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

index 408c2d3f658f3cafc0f158d265f74d3b6a659be2..89f477e3c6bc1162383f7d75127c8d6a23089990 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java

@@ -36,8 +36,7 @@ import java.util.concurrent.TimeUnit;

public class AndroidWebViewTestBase

extends ActivityInstrumentationTestCase2<AndroidWebViewTestRunnerActivity> {

- // TODO(boliu): Revert back to 15 seconds after crbug.com/167236 is fixed.

- protected static int WAIT_TIMEOUT_SECONDS = 90;

+ protected static int WAIT_TIMEOUT_SECONDS = 15;

private static final int CHECK_INTERVAL = 100;

protected static final boolean NORMAL_VIEW = false;

protected static final boolean INCOGNITO_VIEW = true;

« no previous file with comments | « android_webview/browser/aw_browser_main_parts.cc ('k') | android_webview/native/aw_contents.cc » ('j') | no next file with comments »