Issue 11787025: bookmarks: Wait for bookmark model to load by using WaitForBookmarkModelToLoad() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11787025: bookmarks: Wait for bookmark model to load by using WaitForBookmarkModelToLoad() function. (Closed)

Created:
7 years, 11 months ago by tfarina

Modified:
7 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

bookmarks: Wait for bookmark model to load by using WaitForBookmarkModelToLoad() function. By reusing the ui_test_utils::WaitForBookmarkModelToLoad() function we don't need to rely on content::NotificationRegistar/Service nor use chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED. BUG=144783 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175850

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	chrome/browser/ui/bookmarks/bookmark_browsertest.cc	View		1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11787025/1

7 years, 11 months ago (2013-01-09 17:15:56 UTC) #3

Message was sent while issue was closed.

Change committed as 175850

Expand Messages | Collapse Messages