Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 11787024: Replace NOTREACHED that was getting triggered with LOG(WARNING). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility_manager.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
index b604fa6d57c49659b9e97fb776892bc83c97cc77..7b3bf260fd14998e70913fb45fc99de8399e1ce7 100644
--- a/content/browser/accessibility/browser_accessibility_manager.cc
+++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -356,7 +356,8 @@ BrowserAccessibility* BrowserAccessibilityManager::CreateAccessibilityTree(
// and any children. If not, that means we have a serious bug somewhere,
// like the same child is reachable from two places in the same tree.
if (instance && (instance->parent() != NULL || instance->child_count() > 0)) {
- NOTREACHED();
+ // TODO(dmazzoni): investigate this: http://crbug.com/161726
+ LOG(WARNING) << "Reusing node that wasn't detached from parent";
instance = NULL;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698