Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 11787024: Replace NOTREACHED that was getting triggered with LOG(WARNING). (Closed)

Created:
7 years, 11 months ago by dmazzoni
Modified:
7 years, 11 months ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Replace NOTREACHED that was getting triggered with LOG(WARNING). Still need to investigate when this might happen and how to fix it, but this will allow it to just break accessibility rather than crashing the whole browser in the meantime. BUG=161726 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dmazzoni
7 years, 11 months ago (2013-01-07 18:09:33 UTC) #1
aboxhall
LGTM Do you want to revert http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/shell_main_delegate.cc?r1=168504&r2=168503&pathrev=168504 in this change as well?
7 years, 11 months ago (2013-01-07 18:21:58 UTC) #2
jochen (gone - plz use gerrit)
sgtm On Mon, Jan 7, 2013 at 7:21 PM, <aboxhall@chromium.org> wrote: > LGTM > > ...
7 years, 11 months ago (2013-01-07 18:24:38 UTC) #3
dmazzoni
Thanks - I don't see a need to revert the flag removal until we can ...
7 years, 11 months ago (2013-01-07 18:32:16 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 11 months ago (2013-01-07 18:33:18 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 11 months ago (2013-01-07 18:37:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11787024/1
7 years, 11 months ago (2013-01-07 19:22:10 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 21:57:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11787024/1
7 years, 11 months ago (2013-01-07 23:21:34 UTC) #9
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 02:13:32 UTC) #10
Message was sent while issue was closed.
Change committed as 175470

Powered by Google App Engine
This is Rietveld 408576698