Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4376)

Unified Diff: chrome/browser/ui/webui/favicon_source.h

Issue 11787015: Allow the password manager in the settings page to have hidpi favicons too (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/favicon_source.h
diff --git a/chrome/browser/ui/webui/favicon_source.h b/chrome/browser/ui/webui/favicon_source.h
index ea35911856ba6d88538adbe438530b02c61ff1f0..02eae118cb4e217919eef0807ffafc87725414fc 100644
--- a/chrome/browser/ui/webui/favicon_source.h
+++ b/chrome/browser/ui/webui/favicon_source.h
@@ -19,6 +19,38 @@ class Profile;
// FaviconSource is the gateway between network-level chrome:
// requests for favicons and the history backend that serves these.
+//
+// Format:
+// chrome://favicon/size&scalefactor/urlmodifier/url
+// Some parameters are optional as described below. However, the order of the
+// parameters is not interchangeable.
+//
+// Parameter:
+// 'url' Required
+// Specifies the page URL of the requested favicon. If the 'urlmodifier'
+// parameter is 'iconurl', the URL refers to the URL of the favicon image
+// instead.
+// 'size&scalefactor' Optional size/aa@bx/
+// Specifies the requested favicon's size in DIP (aa) and the requested
+// favicon's scale factor. (b).
+// The supported requested DIP sizes are: 16x16, 32x32 and 64x64.
+// If the parameter is unspecified, the requested favicon's size defaults to
+// 16 and the requested scale factor defaults to 1x.
+// Example: chrome://favicon/size/16@2x/http://www.google.com/
+// 'urlmodifier' Optional
+// Values: ['iconurl', 'origin']
+// 'iconurl': Specifies that the url parameter refers to the URL of
+// the favicon image as opposed to the URL of the page that the favicon is
+// on.
+// Example: chrome://favicon/iconurl/http://www.google.com/favicon.ico
+// 'origin': Specifies that the URL should be converted to a form with
+// an empty path and a valid scheme. The converted URL will be used to
+// request the favicon from the favicon service.
+// Examples:
+// chrome://favicon/origin/http://example.com/a
+// chrome://favicon/origin/example.com
+// Both URLs request the favicon for http://example.com from the
+// favicon service.
class FaviconSource : public content::URLDataSource {
public:
// Defines the type of icon the FaviconSource will provide.
@@ -80,6 +112,10 @@ class FaviconSource : public content::URLDataSource {
const IconRequest& request,
const history::FaviconBitmapResult& bitmap_result);
+ // Sends the 16x16 DIP 1x default favicon.
+ void SendDefaultResponse(
+ const content::URLDataSource::GotDataCallback& callback);
+
// Sends the default favicon.
void SendDefaultResponse(const IconRequest& request);
« no previous file with comments | « chrome/browser/resources/suggestions_internals/suggestions_internals.js ('k') | chrome/browser/ui/webui/favicon_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698