Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 11786008: Sanitize the profile's name when used to create a shortcut. (Closed)

Created:
7 years, 11 months ago by macourteau
Modified:
7 years, 11 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews, mgaba
Visibility:
Public.

Description

Sanitize the profile's name when used to create a shortcut. BUG=146640 TEST=unit_tests on Windows pass with --gtest_filter=ProfileShortcutManagerTest.*. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 4 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
macourteau
7 years, 11 months ago (2013-01-08 16:59:03 UTC) #1
Miranda Callahan
On 2013/01/08 16:59:03, macourteau wrote: LGTM, thank you!
7 years, 11 months ago (2013-01-08 17:34:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/11786008/1
7 years, 11 months ago (2013-01-08 18:42:45 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:43:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macourteau@chromium.org/11786008/1
7 years, 11 months ago (2013-01-08 19:26:10 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 22:07:00 UTC) #6
Message was sent while issue was closed.
Change committed as 175593

Powered by Google App Engine
This is Rietveld 408576698