Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: chrome/browser/extensions/convert_web_app_browsertest.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/convert_web_app_browsertest.cc
diff --git a/chrome/browser/extensions/convert_web_app_browsertest.cc b/chrome/browser/extensions/convert_web_app_browsertest.cc
index b773a18c6b704afb6240d325be86cdd1702d9de3..b1e0386e5dc95c403359142d6495ea464e84d054 100644
--- a/chrome/browser/extensions/convert_web_app_browsertest.cc
+++ b/chrome/browser/extensions/convert_web_app_browsertest.cc
@@ -10,7 +10,9 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/extensions/api/icons/icons_handler.h"
#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/permissions/permission_set.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
@@ -82,13 +84,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionFromWebAppTest, Basic) {
EXPECT_TRUE(installed_extension_->HasAPIPermission(
APIPermission::kNotification));
- ASSERT_EQ(3u, installed_extension_->icons().map().size());
- EXPECT_EQ("icons/16.png", installed_extension_->icons().Get(
- 16, ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("icons/48.png", installed_extension_->icons().Get(
- 48, ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("icons/128.png", installed_extension_->icons().Get(
- 128, ExtensionIconSet::MATCH_EXACTLY));
+ const ExtensionIconSet& icons = IconsInfo::GetIcons(installed_extension_);
+ ASSERT_EQ(3u, icons.map().size());
+ EXPECT_EQ("icons/16.png", icons.Get(16, ExtensionIconSet::MATCH_EXACTLY));
+ EXPECT_EQ("icons/48.png", icons.Get(48, ExtensionIconSet::MATCH_EXACTLY));
+ EXPECT_EQ("icons/128.png", icons.Get(128, ExtensionIconSet::MATCH_EXACTLY));
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698