Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2751)

Unified Diff: chrome/common/localized_error.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/localized_error.cc
diff --git a/chrome/common/localized_error.cc b/chrome/common/localized_error.cc
index 73ac296e2ac6ef65bd5ca45cf8bc1100a9809d3f..bfc59a6a443f886256abcbbb4ff77c91e4477543 100644
--- a/chrome/common/localized_error.cc
+++ b/chrome/common/localized_error.cc
@@ -10,6 +10,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/utf_string_conversions.h"
#include "base/values.h"
+#include "chrome/common/extensions/api/icons/icons_handler.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/extension_set.h"
@@ -716,11 +717,15 @@ void LocalizedError::GetAppErrorStrings(
failed_url.c_str()));
error_strings->SetString("title", app->name());
- error_strings->SetString("icon",
- app->GetIconURL(extension_misc::EXTENSION_ICON_GIGANTOR,
- ExtensionIconSet::MATCH_SMALLER).spec());
+ error_strings->SetString(
+ "icon",
+ extensions::IconsInfo::GetIconURL(
+ app,
+ extension_misc::EXTENSION_ICON_GIGANTOR,
+ ExtensionIconSet::MATCH_SMALLER).spec());
error_strings->SetString("name", app->name());
- error_strings->SetString("msg",
+ error_strings->SetString(
+ "msg",
l10n_util::GetStringUTF16(IDS_ERRORPAGES_APP_WARNING));
#if defined(OS_CHROMEOS)

Powered by Google App Engine
This is Rietveld 408576698