Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: chrome/browser/ui/views/script_bubble_view.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/script_bubble_view.cc
diff --git a/chrome/browser/ui/views/script_bubble_view.cc b/chrome/browser/ui/views/script_bubble_view.cc
index 721c3a434750770752f5948355719575e112d164..9e98ab0f5f447e59533d2949f328172958c37ea4 100644
--- a/chrome/browser/ui/views/script_bubble_view.cc
+++ b/chrome/browser/ui/views/script_bubble_view.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/extensions/script_bubble_controller.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/extensions/api/icons/icons_handler.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/page_navigator.h"
@@ -81,8 +82,9 @@ ScriptBubbleView::ScriptBubbleView(views::View* anchor_view,
int size = extension_misc::EXTENSION_ICON_BITTY;
ExtensionResource image =
- extension->GetIconResource(size,
- ExtensionIconSet::MATCH_BIGGER);
+ extensions::IconsInfo::GetIconResource(extension,
+ size,
+ ExtensionIconSet::MATCH_BIGGER);
extensions::ImageLoader::Get(profile)->LoadImageAsync(
extension, image, gfx::Size(size, size),
base::Bind(&ScriptBubbleView::OnImageLoaded, AsWeakPtr(), i));
@@ -162,7 +164,8 @@ void ScriptBubbleView::Init() {
views::ImageView* image_view = new views::ImageView();
entries_[i].extension_imageview = image_view;
image_view->SetImageSize(gfx::Size(16, 16));
- image_view->SetImage(Extension::GetDefaultIcon(false));
+ image_view->SetImage(
+ extensions::IconsInfo::GetDefaultExtensionIcon());
layout->AddView(image_view);
views::Link* link = new views::Link(entries_[i].extension_name);

Powered by Google App Engine
This is Rietveld 408576698