Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc
deleted file mode 100644
index 352be04769c62f284b0f1ed6b2cd531d89105263..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
-#include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_constants.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-TEST_F(ExtensionManifestTest, NormalizeIconPaths) {
- scoped_refptr<extensions::Extension> extension(
- LoadAndExpectSuccess("normalize_icon_paths.json"));
- EXPECT_EQ("16.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_BITTY, ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("48.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_MEDIUM,
- ExtensionIconSet::MATCH_EXACTLY));
-}
-
-TEST_F(ExtensionManifestTest, InvalidIconSizes) {
- scoped_refptr<extensions::Extension> extension(
- LoadAndExpectSuccess("init_ignored_icon_size.json"));
- EXPECT_EQ("",
- extension->icons().Get(300, ExtensionIconSet::MATCH_EXACTLY));
-}
-
-TEST_F(ExtensionManifestTest, ValidIconSizes) {
- scoped_refptr<extensions::Extension> extension(
- LoadAndExpectSuccess("init_valid_icon_size.json"));
- EXPECT_EQ("16.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_BITTY, ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("24.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_SMALLISH,
- ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("32.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_SMALL, ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("48.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_MEDIUM,
- ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("128.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_LARGE, ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("256.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_EXTRA_LARGE,
- ExtensionIconSet::MATCH_EXACTLY));
- EXPECT_EQ("512.png", extension->icons().Get(
- extension_misc::EXTENSION_ICON_GIGANTOR,
- ExtensionIconSet::MATCH_EXACTLY));
-}

Powered by Google App Engine
This is Rietveld 408576698