Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: chrome/browser/ui/views/browser_actions_container_browsertest.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/browser_actions_container.h" 5 #include "chrome/browser/ui/views/browser_actions_container.h"
6 6
7 #include "chrome/browser/extensions/browser_action_test_util.h" 7 #include "chrome/browser/extensions/browser_action_test_util.h"
8 #include "chrome/browser/extensions/extension_action.h" 8 #include "chrome/browser/extensions/extension_action.h"
9 #include "chrome/browser/extensions/extension_action_manager.h" 9 #include "chrome/browser/extensions/extension_action_manager.h"
10 #include "chrome/browser/extensions/extension_browsertest.h" 10 #include "chrome/browser/extensions/extension_browsertest.h"
11 #include "chrome/browser/extensions/extension_service.h" 11 #include "chrome/browser/extensions/extension_service.h"
12 #include "chrome/browser/extensions/extension_system.h" 12 #include "chrome/browser/extensions/extension_system.h"
13 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
14 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
15 #include "chrome/common/chrome_notification_types.h" 15 #include "chrome/common/chrome_notification_types.h"
16 #include "chrome/common/extensions/api/icons/icons_handler.h"
16 #include "chrome/common/extensions/extension_constants.h" 17 #include "chrome/common/extensions/extension_constants.h"
17 #include "chrome/common/extensions/extension_icon_set.h" 18 #include "chrome/common/extensions/extension_icon_set.h"
18 #include "chrome/common/extensions/extension_resource.h" 19 #include "chrome/common/extensions/extension_resource.h"
19 #include "content/public/test/test_utils.h" 20 #include "content/public/test/test_utils.h"
20 21
21 using extensions::Extension; 22 using extensions::Extension;
22 23
23 class BrowserActionsContainerTest : public ExtensionBrowserTest { 24 class BrowserActionsContainerTest : public ExtensionBrowserTest {
24 public: 25 public:
25 BrowserActionsContainerTest() { 26 BrowserActionsContainerTest() {
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 test_data_dir_.AppendASCII("api_test") 259 test_data_dir_.AppendASCII("api_test")
259 .AppendASCII("browser_action") 260 .AppendASCII("browser_action")
260 .AppendASCII("crash_57536")); 261 .AppendASCII("crash_57536"));
261 ASSERT_TRUE(extension); 262 ASSERT_TRUE(extension);
262 263
263 LOG(INFO) << "Creating bitmap\n" << std::flush; 264 LOG(INFO) << "Creating bitmap\n" << std::flush;
264 265
265 // Create and cache and empty bitmap. 266 // Create and cache and empty bitmap.
266 SkBitmap bitmap; 267 SkBitmap bitmap;
267 bitmap.setConfig(SkBitmap::kARGB_8888_Config, 268 bitmap.setConfig(SkBitmap::kARGB_8888_Config,
268 Extension::kBrowserActionIconMaxSize, 269 extensions::IconsInfo::kBrowserActionIconMaxSize,
269 Extension::kBrowserActionIconMaxSize); 270 extensions::IconsInfo::kBrowserActionIconMaxSize);
270 bitmap.allocPixels(); 271 bitmap.allocPixels();
271 272
272 LOG(INFO) << "Set as cached image\n" << std::flush; 273 LOG(INFO) << "Set as cached image\n" << std::flush;
273 274
274 gfx::Size size(Extension::kBrowserActionIconMaxSize, 275 gfx::Size size(extensions::IconsInfo::kBrowserActionIconMaxSize,
275 Extension::kBrowserActionIconMaxSize); 276 extensions::IconsInfo::kBrowserActionIconMaxSize);
276 const ExtensionIconSet* default_icon = 277 const ExtensionIconSet* default_icon =
277 extensions::ExtensionActionManager::Get(browser()->profile())-> 278 extensions::ExtensionActionManager::Get(browser()->profile())->
278 GetBrowserAction(*extension)->default_icon(); 279 GetBrowserAction(*extension)->default_icon();
279 const std::string path = 280 const std::string path =
280 default_icon->Get(extension_misc::EXTENSION_ICON_ACTION, 281 default_icon->Get(extension_misc::EXTENSION_ICON_ACTION,
281 ExtensionIconSet::MATCH_EXACTLY); 282 ExtensionIconSet::MATCH_EXACTLY);
282 283
283 extension->SetCachedImage(extension->GetResource(path), bitmap, size); 284 extension->SetCachedImage(extension->GetResource(path), bitmap, size);
284 285
285 LOG(INFO) << "Disabling extension\n" << std::flush; 286 LOG(INFO) << "Disabling extension\n" << std::flush;
286 DisableExtension(extension->id()); 287 DisableExtension(extension->id());
287 LOG(INFO) << "Enabling extension\n" << std::flush; 288 LOG(INFO) << "Enabling extension\n" << std::flush;
288 EnableExtension(extension->id()); 289 EnableExtension(extension->id());
289 LOG(INFO) << "Test ending\n" << std::flush; 290 LOG(INFO) << "Test ending\n" << std::flush;
290 } 291 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698