Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: chrome/browser/ui/app_list/search_builder.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: License year update Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/app_list/search_builder.h" 5 #include "chrome/browser/ui/app_list/search_builder.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "chrome/browser/autocomplete/autocomplete_classifier.h" 11 #include "chrome/browser/autocomplete/autocomplete_classifier.h"
12 #include "chrome/browser/autocomplete/autocomplete_controller.h" 12 #include "chrome/browser/autocomplete/autocomplete_controller.h"
13 #include "chrome/browser/autocomplete/autocomplete_input.h" 13 #include "chrome/browser/autocomplete/autocomplete_input.h"
14 #include "chrome/browser/autocomplete/autocomplete_match.h" 14 #include "chrome/browser/autocomplete/autocomplete_match.h"
15 #include "chrome/browser/autocomplete/autocomplete_provider.h" 15 #include "chrome/browser/autocomplete/autocomplete_provider.h"
16 #include "chrome/browser/autocomplete/autocomplete_result.h" 16 #include "chrome/browser/autocomplete/autocomplete_result.h"
17 #include "chrome/browser/event_disposition.h" 17 #include "chrome/browser/event_disposition.h"
18 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h" 18 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
19 #include "chrome/browser/extensions/extension_icon_image.h" 19 #include "chrome/browser/extensions/extension_icon_image.h"
20 #include "chrome/browser/extensions/extension_service.h" 20 #include "chrome/browser/extensions/extension_service.h"
21 #include "chrome/browser/profiles/profile.h" 21 #include "chrome/browser/profiles/profile.h"
22 #include "chrome/browser/ui/app_list/app_list_controller.h" 22 #include "chrome/browser/ui/app_list/app_list_controller.h"
23 #include "chrome/browser/ui/browser.h" 23 #include "chrome/browser/ui/browser.h"
24 #include "chrome/browser/ui/browser_navigator.h" 24 #include "chrome/browser/ui/browser_navigator.h"
25 #include "chrome/browser/ui/browser_tabstrip.h" 25 #include "chrome/browser/ui/browser_tabstrip.h"
26 #include "chrome/common/extensions/api/icons/icons_handler.h"
26 #include "chrome/common/extensions/extension.h" 27 #include "chrome/common/extensions/extension.h"
27 #include "chrome/common/extensions/extension_constants.h" 28 #include "chrome/common/extensions/extension_constants.h"
28 #include "chrome/common/extensions/extension_icon_set.h" 29 #include "chrome/common/extensions/extension_icon_set.h"
29 #include "chrome/common/url_constants.h" 30 #include "chrome/common/url_constants.h"
30 #include "content/public/browser/user_metrics.h" 31 #include "content/public/browser/user_metrics.h"
31 #include "content/public/browser/web_contents.h" 32 #include "content/public/browser/web_contents.h"
32 #include "grit/generated_resources.h" 33 #include "grit/generated_resources.h"
33 #include "grit/theme_resources.h" 34 #include "grit/theme_resources.h"
34 #include "ui/app_list/app_list_switches.h" 35 #include "ui/app_list/app_list_switches.h"
35 #include "ui/app_list/search_box_model.h" 36 #include "ui/app_list/search_box_model.h"
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 else 170 else
170 SearchBuilderResult::UpdateIcon(); 171 SearchBuilderResult::UpdateIcon();
171 } 172 }
172 173
173 private: 174 private:
174 void LoadExtensionIcon(const extensions::Extension* extension) { 175 void LoadExtensionIcon(const extensions::Extension* extension) {
175 const gfx::ImageSkia default_icon = extensions::OmniboxAPI::Get(profile())-> 176 const gfx::ImageSkia default_icon = extensions::OmniboxAPI::Get(profile())->
176 GetOmniboxPopupIcon(extension->id()).AsImageSkia(); 177 GetOmniboxPopupIcon(extension->id()).AsImageSkia();
177 icon_.reset(new extensions::IconImage( 178 icon_.reset(new extensions::IconImage(
178 extension, 179 extension,
179 extension->icons(), 180 IconsInfo::GetIcons(extension),
180 extension_misc::EXTENSION_ICON_SMALL, 181 extension_misc::EXTENSION_ICON_SMALL,
181 default_icon, 182 default_icon,
182 this)); 183 this));
183 SetIcon(icon_->image_skia()); 184 SetIcon(icon_->image_skia());
184 } 185 }
185 186
186 // Overridden from extensions::IconImage::Observer: 187 // Overridden from extensions::IconImage::Observer:
187 virtual void OnExtensionIconImageChanged( 188 virtual void OnExtensionIconImageChanged(
188 extensions::IconImage* image) OVERRIDE { 189 extensions::IconImage* image) OVERRIDE {
189 DCHECK_EQ(icon_.get(), image); 190 DCHECK_EQ(icon_.get(), image);
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 result->Init(profile_, *it); 439 result->Init(profile_, *it);
439 results_->Add(result); 440 results_->Add(result);
440 } 441 }
441 } 442 }
442 443
443 void SearchBuilder::OnResultChanged(bool default_match_changed) { 444 void SearchBuilder::OnResultChanged(bool default_match_changed) {
444 // TODO(xiyuan): Handle default match properly. 445 // TODO(xiyuan): Handle default match properly.
445 const AutocompleteResult& ac_result = controller_->result(); 446 const AutocompleteResult& ac_result = controller_->result();
446 PopulateFromACResult(ac_result); 447 PopulateFromACResult(ac_result);
447 } 448 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698