Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: chrome/browser/extensions/extension_web_ui.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Latest master + Yoyo's requests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_web_ui.h" 5 #include "chrome/browser/extensions/extension_web_ui.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "base/utf_string_conversions.h" 12 #include "base/utf_string_conversions.h"
13 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h" 13 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h"
14 #include "chrome/browser/extensions/extension_service.h" 14 #include "chrome/browser/extensions/extension_service.h"
15 #include "chrome/browser/extensions/extension_tab_util.h" 15 #include "chrome/browser/extensions/extension_tab_util.h"
16 #include "chrome/browser/extensions/image_loader.h" 16 #include "chrome/browser/extensions/image_loader.h"
17 #include "chrome/browser/favicon/favicon_util.h" 17 #include "chrome/browser/favicon/favicon_util.h"
18 #include "chrome/browser/prefs/pref_service.h" 18 #include "chrome/browser/prefs/pref_service.h"
19 #include "chrome/browser/prefs/scoped_user_pref_update.h" 19 #include "chrome/browser/prefs/scoped_user_pref_update.h"
20 #include "chrome/browser/profiles/profile.h" 20 #include "chrome/browser/profiles/profile.h"
21 #include "chrome/browser/ui/browser.h" 21 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h" 22 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
23 #include "chrome/common/chrome_switches.h" 23 #include "chrome/common/chrome_switches.h"
24 #include "chrome/common/extensions/api/icons/icons_handler.h"
24 #include "chrome/common/extensions/extension.h" 25 #include "chrome/common/extensions/extension.h"
25 #include "chrome/common/extensions/extension_constants.h" 26 #include "chrome/common/extensions/extension_constants.h"
26 #include "chrome/common/extensions/extension_icon_set.h" 27 #include "chrome/common/extensions/extension_icon_set.h"
27 #include "chrome/common/extensions/extension_resource.h" 28 #include "chrome/common/extensions/extension_resource.h"
28 #include "chrome/common/url_constants.h" 29 #include "chrome/common/url_constants.h"
29 #include "content/public/browser/navigation_controller.h" 30 #include "content/public/browser/navigation_controller.h"
30 #include "content/public/browser/web_contents.h" 31 #include "content/public/browser/web_contents.h"
31 #include "content/public/browser/web_ui.h" 32 #include "content/public/browser/web_ui.h"
32 #include "content/public/common/bindings_policy.h" 33 #include "content/public/common/bindings_policy.h"
33 #include "content/public/common/page_transition_types.h" 34 #include "content/public/common/page_transition_types.h"
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 // resources. Load image reps for all supported scale factors (in addition to 428 // resources. Load image reps for all supported scale factors (in addition to
428 // 1x) immediately instead of in an as needed fashion to be consistent with 429 // 1x) immediately instead of in an as needed fashion to be consistent with
429 // how favicons are requested for chrome:// and page URLs. 430 // how favicons are requested for chrome:// and page URLs.
430 const std::vector<ui::ScaleFactor>& scale_factors = 431 const std::vector<ui::ScaleFactor>& scale_factors =
431 FaviconUtil::GetFaviconScaleFactors(); 432 FaviconUtil::GetFaviconScaleFactors();
432 std::vector<extensions::ImageLoader::ImageRepresentation> info_list; 433 std::vector<extensions::ImageLoader::ImageRepresentation> info_list;
433 for (size_t i = 0; i < scale_factors.size(); ++i) { 434 for (size_t i = 0; i < scale_factors.size(); ++i) {
434 float scale = ui::GetScaleFactorScale(scale_factors[i]); 435 float scale = ui::GetScaleFactorScale(scale_factors[i]);
435 int pixel_size = static_cast<int>(gfx::kFaviconSize * scale); 436 int pixel_size = static_cast<int>(gfx::kFaviconSize * scale);
436 ExtensionResource icon_resource = 437 ExtensionResource icon_resource =
437 extension->GetIconResource(pixel_size, 438 extensions::IconsInfo::GetIconResource(extension,
438 ExtensionIconSet::MATCH_BIGGER); 439 pixel_size,
440 ExtensionIconSet::MATCH_BIGGER);
439 441
440 info_list.push_back( 442 info_list.push_back(
441 extensions::ImageLoader::ImageRepresentation( 443 extensions::ImageLoader::ImageRepresentation(
442 icon_resource, 444 icon_resource,
443 extensions::ImageLoader::ImageRepresentation::ALWAYS_RESIZE, 445 extensions::ImageLoader::ImageRepresentation::ALWAYS_RESIZE,
444 gfx::Size(pixel_size, pixel_size), 446 gfx::Size(pixel_size, pixel_size),
445 scale_factors[i])); 447 scale_factors[i]));
446 } 448 }
447 449
448 // LoadImagesAsync actually can run callback synchronously. We want to force 450 // LoadImagesAsync actually can run callback synchronously. We want to force
449 // async. 451 // async.
450 extensions::ImageLoader::Get(profile)->LoadImagesAsync( 452 extensions::ImageLoader::Get(profile)->LoadImagesAsync(
451 extension, info_list, base::Bind(&RunFaviconCallbackAsync, callback)); 453 extension, info_list, base::Bind(&RunFaviconCallbackAsync, callback));
452 } 454 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698