Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/gtk/action_box_button_gtk.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/action_box_button_gtk.h" 5 #include "chrome/browser/ui/gtk/action_box_button_gtk.h"
6 6
7 #include <gtk/gtk.h> 7 #include <gtk/gtk.h>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/browser/extensions/extension_icon_image.h" 10 #include "chrome/browser/extensions/extension_icon_image.h"
11 #include "chrome/browser/ui/browser.h" 11 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/gtk/custom_button.h" 12 #include "chrome/browser/ui/gtk/custom_button.h"
13 #include "chrome/browser/ui/gtk/view_id_util.h" 13 #include "chrome/browser/ui/gtk/view_id_util.h"
14 #include "chrome/browser/ui/toolbar/action_box_menu_model.h" 14 #include "chrome/browser/ui/toolbar/action_box_menu_model.h"
15 #include "chrome/browser/ui/view_ids.h" 15 #include "chrome/browser/ui/view_ids.h"
16 #include "chrome/common/extensions/api/extension_action/action_info.h" 16 #include "chrome/common/extensions/api/extension_action/action_info.h"
17 #include "chrome/common/extensions/api/icons/icons_handler.h"
17 #include "chrome/common/extensions/extension.h" 18 #include "chrome/common/extensions/extension.h"
18 #include "chrome/common/extensions/extension_constants.h" 19 #include "chrome/common/extensions/extension_constants.h"
19 #include "grit/generated_resources.h" 20 #include "grit/generated_resources.h"
20 #include "grit/theme_resources.h" 21 #include "grit/theme_resources.h"
21 #include "ui/base/l10n/l10n_util.h" 22 #include "ui/base/l10n/l10n_util.h"
22 #include "ui/base/layout.h" 23 #include "ui/base/layout.h"
23 #include "ui/gfx/gtk_util.h" 24 #include "ui/gfx/gtk_util.h"
24 #include "ui/gfx/image/image_skia.h" 25 #include "ui/gfx/image/image_skia.h"
25 #include "ui/gfx/image/image_skia_rep.h" 26 #include "ui/gfx/image/image_skia_rep.h"
26 27
(...skipping 30 matching lines...) Expand all
57 }; 58 };
58 59
59 ExtensionIcon::ExtensionIcon(Profile* profile, const Extension* extension) 60 ExtensionIcon::ExtensionIcon(Profile* profile, const Extension* extension)
60 : image_(NULL) { 61 : image_(NULL) {
61 const ActionInfo* page_launcher_info = 62 const ActionInfo* page_launcher_info =
62 ActionInfo::GetPageLauncherInfo(extension); 63 ActionInfo::GetPageLauncherInfo(extension);
63 icon_.reset(new IconImage(profile, 64 icon_.reset(new IconImage(profile,
64 extension, 65 extension,
65 page_launcher_info->default_icon, 66 page_launcher_info->default_icon,
66 extension_misc::EXTENSION_ICON_ACTION, 67 extension_misc::EXTENSION_ICON_ACTION,
67 Extension::GetDefaultIcon(true), 68 extensions::IconsInfo::GetDefaultAppIcon(),
68 this)); 69 this));
69 UpdateIcon(); 70 UpdateIcon();
70 } 71 }
71 72
72 GtkWidget* ExtensionIcon::GetWidget() { 73 GtkWidget* ExtensionIcon::GetWidget() {
73 return image_; 74 return image_;
74 } 75 }
75 76
76 void ExtensionIcon::OnExtensionIconImageChanged(IconImage* image) { 77 void ExtensionIcon::OnExtensionIconImageChanged(IconImage* image) {
77 DCHECK_EQ(image, icon_.get()); 78 DCHECK_EQ(image, icon_.get());
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 1, 150 1,
150 gtk_get_current_event_time()); 151 gtk_get_current_event_time());
151 } 152 }
152 153
153 gboolean ActionBoxButtonGtk::OnButtonPress(GtkWidget* widget, 154 gboolean ActionBoxButtonGtk::OnButtonPress(GtkWidget* widget,
154 GdkEventButton* event) { 155 GdkEventButton* event) {
155 if (event->button == 1) 156 if (event->button == 1)
156 controller_.OnButtonClicked(); 157 controller_.OnButtonClicked();
157 return FALSE; 158 return FALSE;
158 } 159 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698