Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/ui/ash/launcher/browser_launcher_item_controller.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h" 5 #include "chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h"
6 6
7 #include "ash/launcher/launcher.h" 7 #include "ash/launcher/launcher.h"
8 #include "ash/launcher/launcher_model.h" 8 #include "ash/launcher/launcher_model.h"
9 #include "ash/shell.h" 9 #include "ash/shell.h"
10 #include "ash/wm/window_util.h" 10 #include "ash/wm/window_util.h"
11 #include "chrome/browser/extensions/extension_service.h" 11 #include "chrome/browser/extensions/extension_service.h"
12 #include "chrome/browser/extensions/tab_helper.h" 12 #include "chrome/browser/extensions/tab_helper.h"
13 #include "chrome/browser/favicon/favicon_tab_helper.h" 13 #include "chrome/browser/favicon/favicon_tab_helper.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h" 15 #include "chrome/browser/ui/ash/launcher/chrome_launcher_app_menu_item.h"
16 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h" 16 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
17 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/browser_list.h" 18 #include "chrome/browser/ui/browser_list.h"
19 #include "chrome/browser/ui/browser_window.h" 19 #include "chrome/browser/ui/browser_window.h"
20 #include "chrome/browser/ui/tabs/tab_strip_model.h" 20 #include "chrome/browser/ui/tabs/tab_strip_model.h"
21 #include "chrome/browser/web_applications/web_app.h" 21 #include "chrome/browser/web_applications/web_app.h"
22 #include "chrome/common/extensions/api/icons/icons_handler.h"
22 #include "content/public/browser/web_contents.h" 23 #include "content/public/browser/web_contents.h"
23 #include "grit/ui_resources.h" 24 #include "grit/ui_resources.h"
24 #include "ui/aura/client/aura_constants.h" 25 #include "ui/aura/client/aura_constants.h"
25 #include "ui/aura/window.h" 26 #include "ui/aura/window.h"
26 #include "ui/base/resource/resource_bundle.h" 27 #include "ui/base/resource/resource_bundle.h"
27 #include "ui/views/widget/widget.h" 28 #include "ui/views/widget/widget.h"
28 29
29 using extensions::Extension; 30 using extensions::Extension;
30 31
31 BrowserLauncherItemController::BrowserLauncherItemController( 32 BrowserLauncherItemController::BrowserLauncherItemController(
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 favicon_loader_->GetFavicon()); 308 favicon_loader_->GetFavicon());
308 if (new_image.isNull() && extensions_tab_helper->GetExtensionAppIcon()) { 309 if (new_image.isNull() && extensions_tab_helper->GetExtensionAppIcon()) {
309 new_image = gfx::ImageSkia::CreateFrom1xBitmap( 310 new_image = gfx::ImageSkia::CreateFrom1xBitmap(
310 *extensions_tab_helper->GetExtensionAppIcon()); 311 *extensions_tab_helper->GetExtensionAppIcon());
311 } 312 }
312 // Only update the icon if we have a new image, or none has been set yet. 313 // Only update the icon if we have a new image, or none has been set yet.
313 // This avoids flickering to an empty image when a pinned app is opened. 314 // This avoids flickering to an empty image when a pinned app is opened.
314 if (!new_image.isNull()) 315 if (!new_image.isNull())
315 item.image = new_image; 316 item.image = new_image;
316 else if (item.image.isNull()) 317 else if (item.image.isNull())
317 item.image = extensions::Extension::GetDefaultIcon(true); 318 item.image = extensions::IconsInfo::GetDefaultAppIcon();
318 } else { 319 } else {
319 DCHECK_EQ(TYPE_TABBED, type()); 320 DCHECK_EQ(TYPE_TABBED, type());
320 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); 321 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
321 FaviconTabHelper* favicon_tab_helper = 322 FaviconTabHelper* favicon_tab_helper =
322 FaviconTabHelper::FromWebContents(tab); 323 FaviconTabHelper::FromWebContents(tab);
323 if (favicon_tab_helper->ShouldDisplayFavicon()) { 324 if (favicon_tab_helper->ShouldDisplayFavicon()) {
324 item.image = favicon_tab_helper->GetFavicon().AsImageSkia(); 325 item.image = favicon_tab_helper->GetFavicon().AsImageSkia();
325 if (item.image.isNull()) { 326 if (item.image.isNull()) {
326 item.image = *rb.GetImageSkiaNamed(IDR_DEFAULT_FAVICON); 327 item.image = *rb.GetImageSkiaNamed(IDR_DEFAULT_FAVICON);
327 } 328 }
(...skipping 17 matching lines...) Expand all
345 app_state = ChromeLauncherController::APP_STATE_ACTIVE; 346 app_state = ChromeLauncherController::APP_STATE_ACTIVE;
346 } else { 347 } else {
347 app_state = ChromeLauncherController::APP_STATE_INACTIVE; 348 app_state = ChromeLauncherController::APP_STATE_INACTIVE;
348 } 349 }
349 launcher_controller()->UpdateAppState(tab, app_state); 350 launcher_controller()->UpdateAppState(tab, app_state);
350 } 351 }
351 352
352 ash::LauncherModel* BrowserLauncherItemController::launcher_model() { 353 ash::LauncherModel* BrowserLauncherItemController::launcher_model() {
353 return launcher_controller()->model(); 354 return launcher_controller()->model();
354 } 355 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698