Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: chrome/browser/extensions/convert_web_app_unittest.cc

Issue 11786003: Move Icons out of Extension class (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/convert_web_app.h" 5 #include "chrome/browser/extensions/convert_web_app.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/file_util.h" 10 #include "base/file_util.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/files/scoped_temp_dir.h" 12 #include "base/files/scoped_temp_dir.h"
13 #include "base/path_service.h" 13 #include "base/path_service.h"
14 #include "base/stringprintf.h" 14 #include "base/stringprintf.h"
15 #include "base/time.h" 15 #include "base/time.h"
16 #include "base/utf_string_conversions.h" 16 #include "base/utf_string_conversions.h"
17 #include "base/version.h" 17 #include "base/version.h"
18 #include "chrome/common/chrome_paths.h" 18 #include "chrome/common/chrome_paths.h"
19 #include "chrome/common/extensions/api/icons/icons_handler.h"
19 #include "chrome/common/extensions/extension.h" 20 #include "chrome/common/extensions/extension.h"
20 #include "chrome/common/extensions/extension_icon_set.h" 21 #include "chrome/common/extensions/extension_icon_set.h"
21 #include "chrome/common/extensions/extension_resource.h" 22 #include "chrome/common/extensions/extension_resource.h"
22 #include "chrome/common/extensions/permissions/permission_set.h" 23 #include "chrome/common/extensions/permissions/permission_set.h"
23 #include "chrome/common/web_apps.h" 24 #include "chrome/common/web_apps.h"
24 #include "extensions/common/url_pattern.h" 25 #include "extensions/common/url_pattern.h"
25 #include "googleurl/src/gurl.h" 26 #include "googleurl/src/gurl.h"
26 #include "testing/gtest/include/gtest/gtest.h" 27 #include "testing/gtest/include/gtest/gtest.h"
27 #include "ui/gfx/codec/png_codec.h" 28 #include "ui/gfx/codec/png_codec.h"
28 #include "webkit/glue/image_decoder.h" 29 #include "webkit/glue/image_decoder.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name()); 131 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name());
131 EXPECT_EQ(UTF16ToUTF8(web_app.description), extension->description()); 132 EXPECT_EQ(UTF16ToUTF8(web_app.description), extension->description());
132 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL()); 133 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL());
133 EXPECT_EQ(2u, extension->GetActivePermissions()->apis().size()); 134 EXPECT_EQ(2u, extension->GetActivePermissions()->apis().size());
134 EXPECT_TRUE(extension->HasAPIPermission("geolocation")); 135 EXPECT_TRUE(extension->HasAPIPermission("geolocation"));
135 EXPECT_TRUE(extension->HasAPIPermission("notifications")); 136 EXPECT_TRUE(extension->HasAPIPermission("notifications"));
136 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 137 ASSERT_EQ(1u, extension->web_extent().patterns().size());
137 EXPECT_EQ("http://aaronboodman.com/gearpad/*", 138 EXPECT_EQ("http://aaronboodman.com/gearpad/*",
138 extension->web_extent().patterns().begin()->GetAsString()); 139 extension->web_extent().patterns().begin()->GetAsString());
139 140
140 EXPECT_EQ(web_app.icons.size(), extension->icons().map().size()); 141 EXPECT_EQ(web_app.icons.size(), IconsInfo::GetIcons(extension).map().size());
141 for (size_t i = 0; i < web_app.icons.size(); ++i) { 142 for (size_t i = 0; i < web_app.icons.size(); ++i) {
142 EXPECT_EQ(StringPrintf("icons/%i.png", web_app.icons[i].width), 143 EXPECT_EQ(StringPrintf("icons/%i.png", web_app.icons[i].width),
143 extension->icons().Get(web_app.icons[i].width, 144 IconsInfo::GetIcons(extension).Get(
144 ExtensionIconSet::MATCH_EXACTLY)); 145 web_app.icons[i].width, ExtensionIconSet::MATCH_EXACTLY));
145 ExtensionResource resource = extension->GetIconResource( 146 ExtensionResource resource = IconsInfo::GetIconResource(
146 web_app.icons[i].width, ExtensionIconSet::MATCH_EXACTLY); 147 extension, web_app.icons[i].width, ExtensionIconSet::MATCH_EXACTLY);
147 ASSERT_TRUE(!resource.empty()); 148 ASSERT_TRUE(!resource.empty());
148 EXPECT_TRUE(file_util::PathExists(resource.GetFilePath())); 149 EXPECT_TRUE(file_util::PathExists(resource.GetFilePath()));
149 } 150 }
150 } 151 }
151 152
152 TEST(ExtensionFromWebApp, Minimal) { 153 TEST(ExtensionFromWebApp, Minimal) {
153 base::ScopedTempDir extensions_dir; 154 base::ScopedTempDir extensions_dir;
154 ASSERT_TRUE(extensions_dir.CreateUniqueTempDir()); 155 ASSERT_TRUE(extensions_dir.CreateUniqueTempDir());
155 156
156 WebApplicationInfo web_app; 157 WebApplicationInfo web_app;
(...skipping 13 matching lines...) Expand all
170 EXPECT_TRUE(extension->is_hosted_app()); 171 EXPECT_TRUE(extension->is_hosted_app());
171 EXPECT_FALSE(extension->is_legacy_packaged_app()); 172 EXPECT_FALSE(extension->is_legacy_packaged_app());
172 173
173 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=", 174 EXPECT_EQ("lJqm1+jncOHClAuwif1QxNJKfeV9Fbl9IBZx7FkNwkA=",
174 extension->public_key()); 175 extension->public_key());
175 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id()); 176 EXPECT_EQ("ncnbaadanljoanockmphfdkimpdedemj", extension->id());
176 EXPECT_EQ("1978.12.11.0", extension->version()->GetString()); 177 EXPECT_EQ("1978.12.11.0", extension->version()->GetString());
177 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name()); 178 EXPECT_EQ(UTF16ToUTF8(web_app.title), extension->name());
178 EXPECT_EQ("", extension->description()); 179 EXPECT_EQ("", extension->description());
179 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL()); 180 EXPECT_EQ(web_app.app_url, extension->GetFullLaunchURL());
180 EXPECT_EQ(0u, extension->icons().map().size()); 181 EXPECT_EQ(0u, IconsInfo::GetIcons(extension).map().size());
181 EXPECT_EQ(0u, extension->GetActivePermissions()->apis().size()); 182 EXPECT_EQ(0u, extension->GetActivePermissions()->apis().size());
182 ASSERT_EQ(1u, extension->web_extent().patterns().size()); 183 ASSERT_EQ(1u, extension->web_extent().patterns().size());
183 EXPECT_EQ("*://aaronboodman.com/*", 184 EXPECT_EQ("*://aaronboodman.com/*",
184 extension->web_extent().patterns().begin()->GetAsString()); 185 extension->web_extent().patterns().begin()->GetAsString());
185 } 186 }
186 187
187 } // namespace extensions 188 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698