Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2381)

Unified Diff: android_webview/native/aw_contents.cc

Issue 11785011: Remove incognito parameter from AwContents (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebaselining findbugs, my fix removed a bug entry Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_contents.h ('k') | build/android/findbugs_filter/findbugs_known_bugs.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index 2343b6a7839f02f9811c6b7b8814addaea30df88..e858c38eaae6858c98c4e5e6f17d3a4711dd662a 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -114,8 +114,7 @@ AwContents* AwContents::FromWebContents(WebContents* web_contents) {
AwContents::AwContents(JNIEnv* env,
jobject obj,
- jobject web_contents_delegate,
- bool private_browsing)
+ jobject web_contents_delegate)
: java_ref_(env, obj),
web_contents_delegate_(
new AwWebContentsDelegate(env, web_contents_delegate)),
@@ -131,7 +130,7 @@ AwContents::AwContents(JNIEnv* env,
// TODO(joth): rather than create and set the WebContents here, expose the
// factory method to java side and have that orchestrate the construction
// order.
- SetWebContents(dependency_factory->CreateWebContents(private_browsing));
+ SetWebContents(dependency_factory->CreateWebContents());
}
void AwContents::ResetCompositor() {
@@ -611,10 +610,8 @@ void AwContents::SetInterceptNavigationDelegate(JNIEnv* env,
static jint Init(JNIEnv* env,
jobject obj,
- jobject web_contents_delegate,
- jboolean private_browsing) {
- AwContents* tab = new AwContents(env, obj, web_contents_delegate,
- private_browsing);
+ jobject web_contents_delegate) {
+ AwContents* tab = new AwContents(env, obj, web_contents_delegate);
return reinterpret_cast<jint>(tab);
}
« no previous file with comments | « android_webview/native/aw_contents.h ('k') | build/android/findbugs_filter/findbugs_known_bugs.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698