Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 11785002: Fix regression with audio mirroring due to observers being added while iterating over the list of ob (Closed)

Created:
7 years, 11 months ago by justinlin
Modified:
7 years, 11 months ago
Reviewers:
DaleCurtis, miu
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix regression with audio mirroring due to observers being added while iterating over the list of observers which causes an infinite loop. BUG=168362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175282

Patch Set 1 #

Total comments: 2

Patch Set 2 : real fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/audio/audio_manager_base.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
justinlin
7 years, 11 months ago (2013-01-04 20:20:37 UTC) #1
miu
https://codereview.chromium.org/11785002/diff/1/media/audio/audio_output_controller.cc File media/audio/audio_output_controller.cc (right): https://codereview.chromium.org/11785002/diff/1/media/audio/audio_output_controller.cc#newcode144 media/audio/audio_output_controller.cc:144: if (state_ != kRecreating) This will leave us in ...
7 years, 11 months ago (2013-01-04 21:57:56 UTC) #2
miu
From the bug description, it looks like there might be a thread-blocking issue. Can you ...
7 years, 11 months ago (2013-01-04 22:06:22 UTC) #3
miu1
It just occurred to me: maybe the issue is that change listeners are being removed ...
7 years, 11 months ago (2013-01-04 22:30:51 UTC) #4
justinlin
https://codereview.chromium.org/11785002/diff/1/media/audio/audio_output_controller.cc File media/audio/audio_output_controller.cc (right): https://codereview.chromium.org/11785002/diff/1/media/audio/audio_output_controller.cc#newcode144 media/audio/audio_output_controller.cc:144: if (state_ != kRecreating) On 2013/01/04 21:57:56, Yuri wrote: ...
7 years, 11 months ago (2013-01-04 22:31:02 UTC) #5
justinlin
On 2013/01/04 22:30:51, miu_google.com wrote: > It just occurred to me: maybe the issue is ...
7 years, 11 months ago (2013-01-04 23:11:03 UTC) #6
miu
lgtm
7 years, 11 months ago (2013-01-04 23:14:34 UTC) #7
DaleCurtis
lgtm
7 years, 11 months ago (2013-01-04 23:34:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11785002/6001
7 years, 11 months ago (2013-01-04 23:35:26 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-05 00:55:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/11785002/6001
7 years, 11 months ago (2013-01-05 00:56:18 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 04:22:23 UTC) #12
Message was sent while issue was closed.
Change committed as 175282

Powered by Google App Engine
This is Rietveld 408576698