Issue 11784036: [gtk] Fix file filter bug for <input type=file accept=mime/type>.

Issue 11784036: [gtk] Fix file filter bug for <input type=file accept=mime/type>. (Closed)

Created:
7 years, 11 months ago by Dan Beam

Modified:
7 years, 11 months ago

Reviewers:
Elliot Glaysher, sky, Evan Stade

CC:
chromium-reviews, Kyle Horimoto

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[gtk] Fix file filter bug for <input type=file accept=mime/type>. R=sky@chromium.org TEST=Repro steps in bug #168746. BUG=166348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175674

Patch Set 4 : erg@ review #

Total comments: 8

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
	M	chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc	View	1 2 3	2 chunks	+20 lines, -3 lines	0 comments	Download
	M	ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc	View	1 2 3	2 chunks	+20 lines, -3 lines	8 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

Please make the exact same changes to chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc, which is the long term version of ...

7 years, 11 months ago (2013-01-08 18:55:59 UTC) #3

Dan Beam

On 2013/01/08 18:55:59, Elliot Glaysher wrote: > Please make the exact same changes to > ...

7 years, 11 months ago (2013-01-08 20:52:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11784036/6001

7 years, 11 months ago (2013-01-08 20:55:35 UTC) #6

Evan Stade

https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc File ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc (right): https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc#newcode28 ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:28: gpointer data) { just make data a std::string* https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc#newcode243 ...

7 years, 11 months ago (2013-01-10 01:50:06 UTC) #8

Dan Beam

7 years, 11 months ago (2013-01-10 05:37:08 UTC) #9

Message was sent while issue was closed.

follow up stuff here: https://chromiumcodereview.appspot.com/11778082/

https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk...
File ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc (right):

https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk...
ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:28: gpointer data) {
On 2013/01/10 01:50:06, Evan Stade wrote:
> just make data a std::string*

Done.

https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk...
ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:243: std::string*
file_extension = new std::string("." + current_extension);
On 2013/01/10 01:50:06, Evan Stade wrote:
> scoped_ptr for clarity (and .release() it to the function)

Done.

https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk...
ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:247:
reinterpret_cast<gpointer>(file_extension),
On 2013/01/10 01:50:06, Evan Stade wrote:
> sure this cast is necessary?

Nope, it's not.

https://chromiumcodereview.appspot.com/11784036/diff/6001/ui/base/dialogs/gtk...
ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:249:
fallback_labels.insert(std::string("*").append(*file_extension));
On 2013/01/10 01:50:06, Evan Stade wrote:
> you should not use file_extension after you've handed off ownership.

Done.

Expand Messages | Collapse Messages