Add VisibleForTesting to content/public/android

Add VisibleForTesting to content/public/android

BUG=168615
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175537

[aruslan, 2013-01-07 21:14:11]

Please take a look; is "content_java" a right target to add the dependency?
I'll add content/content.gyp OWNERS if the CL makes sense.

[Yaron, 2013-01-07 23:28:19]

lgtm

[aruslan, 2013-01-07 23:55:32]

avi@ -- please take a look at content/content.gyp and apply OWNERS seal, thanks!

[Avi (use Gerrit), 2013-01-08 03:10:29]

lgtm

stampity stamp with questions

https://chromiumcodereview.appspot.com/11784028/diff/5002/chrome/android/java...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
(right):

https://chromiumcodereview.appspot.com/11784028/diff/5002/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java:730:
public BookmarkNode(long id, Type type, String name, String url, BookmarkNode
parent) {
Uh, the TODO said to remove public. Was it incorrect?

[aruslan, 2013-01-08 03:48:28]

Thank you!

https://chromiumcodereview.appspot.com/11784028/diff/5002/chrome/android/java...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
(right):

https://chromiumcodereview.appspot.com/11784028/diff/5002/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java:730:
public BookmarkNode(long id, Type type, String name, String url, BookmarkNode
parent) {
On 2013/01/08 03:10:29, Avi wrote:
> Uh, the TODO said to remove public. Was it incorrect?

Yes; judging from the name I assumed that there is some magic that would make
the name visible and accessible for the test targets :)
Turns out, it's just a convention.

[Avi (use Gerrit), 2013-01-08 04:46:20]

On 2013/01/08 03:48:28, aruslan wrote:
> Thank you!
> 
>
https://chromiumcodereview.appspot.com/11784028/diff/5002/chrome/android/java...
> File
> chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
> (right):
> 
>
https://chromiumcodereview.appspot.com/11784028/diff/5002/chrome/android/java...
>
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java:730:
> public BookmarkNode(long id, Type type, String name, String url, BookmarkNode
> parent) {
> On 2013/01/08 03:10:29, Avi wrote:
> > Uh, the TODO said to remove public. Was it incorrect?
> 
> Yes; judging from the name I assumed that there is some magic that would make
> the name visible and accessible for the test targets :)
> Turns out, it's just a convention.

Ah, makes sense. Land away!

[commit-bot: I haz the power, 2013-01-08 13:55:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aruslan@chromium.org/11784028/5002

[commit-bot: I haz the power, 2013-01-08 16:44:17]

Change committed as 175537