Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 11783112: Remove the NaCl SRPC proxy from Chrome. (Closed)

Created:
7 years, 11 months ago by bbudge
Modified:
7 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yzshen+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, piman+watch_chromium.org, native-client-reviews_googlegroups.com, ihf+watch_chromium.org
Visibility:
Public.

Description

Remove the NaCl SRPC proxy from Chrome. Removes GYP targets for untrusted and trusted parts of the proxy (SRPC proxy source files will be removed in a follow-on, to keep this patch manageable.) Removes SRPC proxy startup code from NaCl trusted plugin. Removes PPAPI PPP* interface adapters from the Plugin class. Removes a bunch of GYP external dependency declarations that are no longer needed. TBR=brettw@chromium.org for OWNERS BUG=169152 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177531

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 12

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -631 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_browser.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 5 chunks +5 lines, -11 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/nacl_cmd_line.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/nacl.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 1 2 3 1 chunk +0 lines, -150 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_subprocess.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_subprocess.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 2 7 chunks +2 lines, -51 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 2 3 14 chunks +7 lines, -379 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/srpc_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/srpc_client.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bbudge
Mark for chrome/ David and David for ppapi/
7 years, 11 months ago (2013-01-16 23:56:52 UTC) #1
Mark Seaborn
LGTM https://codereview.chromium.org/11783112/diff/31075/ppapi/c/private/ppb_flash_font_file.h File ppapi/c/private/ppb_flash_font_file.h (right): https://codereview.chromium.org/11783112/diff/31075/ppapi/c/private/ppb_flash_font_file.h#newcode6 ppapi/c/private/ppb_flash_font_file.h:6: /* From private/ppb_flash_font_file.idl modified Wed Jan 2 14:34:38 ...
7 years, 11 months ago (2013-01-17 00:25:58 UTC) #2
dmichael (off chromium)
Awesome! couple nits, o/w lgtm I assume you are planning to delete the actual ppapi_proxy ...
7 years, 11 months ago (2013-01-17 17:43:15 UTC) #3
bbudge
David, I left deleting the source files for a separate patch, as it's very large. ...
7 years, 11 months ago (2013-01-17 19:07:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/11783112/23068
7 years, 11 months ago (2013-01-17 20:27:22 UTC) #5
commit-bot: I haz the power
Presubmit check for 11783112-23068 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-17 20:27:31 UTC) #6
bbudge
+jam for chrome/ This is a simple removal of the NaCl PPAPI proxy flag.
7 years, 11 months ago (2013-01-17 20:32:01 UTC) #7
sehr (please use chromium)
lgtm
7 years, 11 months ago (2013-01-17 20:35:50 UTC) #8
sehr
lgtm
7 years, 11 months ago (2013-01-17 20:38:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/11783112/23068
7 years, 11 months ago (2013-01-17 21:08:21 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) sync_integration_tests
7 years, 11 months ago (2013-01-17 21:37:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/11783112/23068
7 years, 11 months ago (2013-01-17 21:44:18 UTC) #12
commit-bot: I haz the power
7 years, 11 months ago (2013-01-17 23:39:44 UTC) #13
Message was sent while issue was closed.
Change committed as 177531

Powered by Google App Engine
This is Rietveld 408576698