Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: third_party/cld/cld.gyp

Issue 11783096: disable c4267 in cld for building on win x64 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix crazy gyp formatting Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cld/cld.gyp
diff --git a/third_party/cld/cld.gyp b/third_party/cld/cld.gyp
index b2db4c7bc23f6ac19e5fd0061f07d5684e1ce57c..4813f48cb09ccb3b5b31a6237ebbe7bf880c5667 100644
--- a/third_party/cld/cld.gyp
+++ b/third_party/cld/cld.gyp
@@ -101,22 +101,20 @@
},
'conditions': [
['OS=="win"', {
- 'direct_dependent_settings': {
- 'defines': [
- 'COMPILER_MSVC',
- ],
- },
- 'msvs_disabled_warnings': [4005, 4006, 4018, 4244, 4309, 4800],
- },
- ],
- ['OS!="win"', {
- 'direct_dependent_settings': {
- 'defines': [
- 'COMPILER_GCC',
- ],
- },
- },
- ],
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'COMPILER_MSVC',
+ ],
+ },
+ # TODO(jschuh): C4267: http://crbug.com/167187 size_t -> int
+ 'msvs_disabled_warnings': [4005, 4006, 4018, 4244, 4309, 4800, 4267],
+ }, {
+ 'direct_dependent_settings': {
+ 'defines': [
+ 'COMPILER_GCC',
+ ],
+ },
+ }],
],
},
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698