Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6100)

Unified Diff: chrome/browser/webdata/web_data_request_manager.cc

Issue 11783091: Remove GenericRequest templates from WebDataService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Switch result_ to scopted_ptr Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/web_data_request_manager.h ('k') | chrome/browser/webdata/web_data_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/web_data_request_manager.cc
diff --git a/chrome/browser/webdata/web_data_request_manager.cc b/chrome/browser/webdata/web_data_request_manager.cc
index f79764eaa25698bd9ef7957ae13d8628affb0cf0..cf3e6130ff396aef213012cf3cbef73e8d00c656 100644
--- a/chrome/browser/webdata/web_data_request_manager.cc
+++ b/chrome/browser/webdata/web_data_request_manager.cc
@@ -30,7 +30,6 @@ WebDataRequest::WebDataRequest(WebDataService* service,
}
WebDataRequest::~WebDataRequest() {
- delete result_;
}
WebDataService::Handle WebDataRequest::GetHandle() const {
@@ -52,12 +51,12 @@ void WebDataRequest::Cancel() {
consumer_ = NULL;
}
-void WebDataRequest::SetResult(WDTypedResult* r) {
- result_ = r;
+void WebDataRequest::SetResult(scoped_ptr<WDTypedResult> r) {
+ result_ = r.Pass();
}
const WDTypedResult* WebDataRequest::GetResult() const {
- return result_;
+ return result_.get();
}
void WebDataRequest::RequestComplete() {
« no previous file with comments | « chrome/browser/webdata/web_data_request_manager.h ('k') | chrome/browser/webdata/web_data_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698