Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Side by Side Diff: chrome/browser/webdata/web_data_service_win.cc

Issue 11783091: Remove GenericRequest templates from WebDataService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Switch result_ to scopted_ptr Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/webdata/web_data_service.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/webdata/logins_table.h" 5 #include "chrome/browser/webdata/logins_table.h"
6 #include "chrome/browser/webdata/web_data_service.h" 6 #include "chrome/browser/webdata/web_data_service.h"
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "chrome/browser/password_manager/ie7_password.h" 9 #include "chrome/browser/password_manager/ie7_password.h"
10 #include "chrome/browser/webdata/web_database.h" 10 #include "chrome/browser/webdata/web_database.h"
11 11
12 using base::Bind; 12 using base::Bind;
13 13
14 void WebDataService::AddIE7Login(const IE7PasswordInfo& info) { 14 void WebDataService::AddIE7Login(const IE7PasswordInfo& info) {
15 GenericRequest<IE7PasswordInfo>* request = 15 ScheduleDBTask(FROM_HERE,
16 new GenericRequest<IE7PasswordInfo>(this, NULL, &request_manager_, info); 16 Bind(&WebDataService::AddIE7LoginImpl, this, info));
17 ScheduleTask(FROM_HERE,
18 Bind(&WebDataService::AddIE7LoginImpl, this, request));
19 } 17 }
20 18
21 void WebDataService::RemoveIE7Login(const IE7PasswordInfo& info) { 19 void WebDataService::RemoveIE7Login(const IE7PasswordInfo& info) {
22 GenericRequest<IE7PasswordInfo>* request = 20 ScheduleDBTask(FROM_HERE,
23 new GenericRequest<IE7PasswordInfo>(this, NULL, &request_manager_, info); 21 Bind(&WebDataService::RemoveIE7LoginImpl, this, info));
24 ScheduleTask(FROM_HERE,
25 Bind(&WebDataService::RemoveIE7LoginImpl, this, request));
26 } 22 }
27 23
28 WebDataService::Handle WebDataService::GetIE7Login( 24 WebDataService::Handle WebDataService::GetIE7Login(
29 const IE7PasswordInfo& info, 25 const IE7PasswordInfo& info,
30 WebDataServiceConsumer* consumer) { 26 WebDataServiceConsumer* consumer) {
31 GenericRequest<IE7PasswordInfo>* request = 27 return ScheduleDBTaskWithResult(FROM_HERE,
32 new GenericRequest<IE7PasswordInfo>(this, consumer, &request_manager_, 28 Bind(&WebDataService::GetIE7LoginImpl, this, info), consumer);
33 info);
34 ScheduleTask(FROM_HERE,
35 Bind(&WebDataService::GetIE7LoginImpl, this, request));
36 return request->GetHandle();
37 } 29 }
38 30
39 void WebDataService::AddIE7LoginImpl(GenericRequest<IE7PasswordInfo>* request) { 31 void WebDataService::AddIE7LoginImpl(const IE7PasswordInfo& info) {
40 if (db_ && !request->IsCancelled()) { 32 if (db_->GetLoginsTable()->AddIE7Login(info))
41 if (db_->GetLoginsTable()->AddIE7Login(request->arg()))
42 ScheduleCommit(); 33 ScheduleCommit();
43 }
44 request->RequestComplete();
45 } 34 }
46 35
47 void WebDataService::RemoveIE7LoginImpl( 36 void WebDataService::RemoveIE7LoginImpl(const IE7PasswordInfo& info) {
48 GenericRequest<IE7PasswordInfo>* request) { 37 if (db_->GetLoginsTable()->RemoveIE7Login(info))
49 if (db_ && !request->IsCancelled()) { 38 ScheduleCommit();
50 if (db_->GetLoginsTable()->RemoveIE7Login(request->arg()))
51 ScheduleCommit();
52 }
53 request->RequestComplete();
54 } 39 }
55 40
56 void WebDataService::GetIE7LoginImpl( 41 scoped_ptr<WDTypedResult> WebDataService::GetIE7LoginImpl(
57 GenericRequest<IE7PasswordInfo>* request) { 42 const IE7PasswordInfo& info) {
58 if (db_ && !request->IsCancelled()) {
59 IE7PasswordInfo result; 43 IE7PasswordInfo result;
60 db_->GetLoginsTable()->GetIE7Login(request->arg(), &result); 44 db_->GetLoginsTable()->GetIE7Login(info, &result);
61 request->SetResult( 45 return scoped_ptr<WDTypedResult>(
62 new WDResult<IE7PasswordInfo>(PASSWORD_IE7_RESULT, result)); 46 new WDResult<IE7PasswordInfo>(PASSWORD_IE7_RESULT, result));
63 }
64 request->RequestComplete();
65 } 47 }
OLDNEW
« no previous file with comments | « chrome/browser/webdata/web_data_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698