Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 11783056: [telemetry] More fixes for my page_test_result rewrite (Closed)

Created:
7 years, 11 months ago by nduca
Modified:
7 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] More fixes for my page_test_result rewrite TBR=tonyg@chromium.org NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -19 lines) Patch
M tools/perf/perf_tools/skpicture_printer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/perf_tools/smoothness_benchmark_unittest.py View 4 chunks +12 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/csv_page_benchmark_results.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/multi_page_benchmark_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/multi_page_benchmark_unittest_base.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/page_benchmark_results.py View 3 chunks +26 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page_runner.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nduca
(sheriffs: note, this affects code that doesn't run anywhere, hence NOTRY)
7 years, 11 months ago (2013-01-09 10:37:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11783056/1
7 years, 11 months ago (2013-01-09 10:38:17 UTC) #2
commit-bot: I haz the power
Change committed as 175770
7 years, 11 months ago (2013-01-09 10:41:37 UTC) #3
tonyg
7 years, 11 months ago (2013-01-09 18:12:06 UTC) #4
Message was sent while issue was closed.
On 2013/01/09 10:41:37, I haz the power (commit-bot) wrote:
> Change committed as 175770

lgtm

Powered by Google App Engine
This is Rietveld 408576698