Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 11783053: Clean Up: Remove ibus namespace. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka
Modified:
7 years, 10 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove ibus namespace. ibus namespace is temporary introduced for avoiding name collision with libibus. So it's time to remove ibus namespace because libibus is already gone. BUG=None TEST=try bots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179889

Patch Set 1 : fix ui_unittests #

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -379 lines) Patch
M chrome/browser/chromeos/input_method/candidate_view.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.h View 1 2 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl_unittest.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view.cc View 1 2 25 chunks +34 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc View 1 2 8 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 2 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.h View 1 2 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 2 13 chunks +31 lines, -32 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/ibus_client.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chromeos/dbus/ibus/ibus_client.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_component.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_component.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_component_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/dbus/ibus/ibus_config_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service.h View 1 2 4 chunks +6 lines, -17 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service.cc View 1 2 9 chunks +12 lines, -13 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service_unittest.cc View 1 2 18 chunks +29 lines, -29 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.h View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/ibus/ibus_lookup_table.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_lookup_table.cc View 1 2 4 chunks +2 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/ibus_lookup_table_unittest.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_object.h View 5 chunks +6 lines, -9 lines 0 comments Download
M chromeos/dbus/ibus/ibus_object.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M chromeos/dbus/ibus/ibus_object_unittest.cc View 4 chunks +2 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service.h View 1 2 4 chunks +3 lines, -6 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service.cc View 1 2 7 chunks +8 lines, -11 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service_unittest.cc View 1 2 14 chunks +16 lines, -19 lines 0 comments Download
M chromeos/dbus/ibus/ibus_property.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/dbus/ibus/ibus_property.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/ibus_property_unittest.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_text.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_text.cc View 1 2 3 chunks +1 line, -4 lines 0 comments Download
M chromeos/dbus/ibus/ibus_text_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_client.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_engine_service.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_engine_service.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_panel_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_panel_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/ime/input_method_ibus.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_ibus.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M ui/base/ime/input_method_ibus_unittest.cc View 1 2 7 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Seigo Nonaka
7 years, 11 months ago (2013-01-09 07:00:41 UTC) #1
Seigo Nonaka
ping, just in case.
7 years, 11 months ago (2013-01-10 07:54:20 UTC) #2
satorux1
LGTM, but you should probably wait for a while, as patches like this will make ...
7 years, 11 months ago (2013-01-10 08:21:06 UTC) #3
Seigo Nonaka
On 2013/01/10 08:21:06, satorux1 wrote: > LGTM, but you should probably wait for a while, ...
7 years, 11 months ago (2013-01-11 04:52:52 UTC) #4
satorux1
it's probably ok to land this.
7 years, 10 months ago (2013-01-29 05:19:26 UTC) #5
Seigo Nonaka
Sure, will rebase and submit after submit all current pending changes. Thanks
7 years, 10 months ago (2013-01-31 03:28:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11783053/20001
7 years, 10 months ago (2013-01-31 13:44:40 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 15:50:30 UTC) #8
Message was sent while issue was closed.
Change committed as 179889

Powered by Google App Engine
This is Rietveld 408576698