Issue 11783045: [Autofill] Ensure that clients pass the correct region info when parsing phone numbers.

Issue 11783045: [Autofill] Ensure that clients pass the correct region info when parsing phone numbers. (Closed)

Created:
7 years, 11 months ago by Ilya Sherman

Modified:
7 years, 11 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Autofill] Ensure that clients pass the correct region info when parsing phone numbers. BUG=100845 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175975

Patch Set 1 #

Total comments: 2

Patch Set 2 : Semicomma #

Patch Set 3 : Clean up Windows import code #

Patch Set 4 : Fix compile #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -55 lines)			Patch
M	chrome/browser/autofill/autofill_ie_toolbar_import_win.cc	View	1 2 3	6 chunks	+44 lines, -24 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/autofill/phone_number.h	View		2 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/autofill/phone_number.cc	View		5 chunks	+27 lines, -15 lines	0 comments	Download
M	chrome/browser/autofill/phone_number_unittest.cc	View		5 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

dhollowa

lgtm https://chromiumcodereview.appspot.com/11783045/diff/1/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc File chrome/browser/autofill/autofill_ie_toolbar_import_win.cc (right): https://chromiumcodereview.appspot.com/11783045/diff/1/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc#newcode161 chrome/browser/autofill/autofill_ie_toolbar_import_win.cc:161: const std::string app_locale = AutofillCountry::ApplicationLocale(), win compile problem.

7 years, 11 months ago (2013-01-09 01:26:54 UTC) #2

Ilya Sherman

https://chromiumcodereview.appspot.com/11783045/diff/1/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc File chrome/browser/autofill/autofill_ie_toolbar_import_win.cc (right): https://chromiumcodereview.appspot.com/11783045/diff/1/chrome/browser/autofill/autofill_ie_toolbar_import_win.cc#newcode161 chrome/browser/autofill/autofill_ie_toolbar_import_win.cc:161: const std::string app_locale = AutofillCountry::ApplicationLocale(), On 2013/01/09 01:26:54, dhollowa ...

7 years, 11 months ago (2013-01-09 01:29:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11783045/12

7 years, 11 months ago (2013-01-09 01:30:40 UTC) #4

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 11 months ago (2013-01-09 02:42:42 UTC) #5

Ilya Sherman

There were further Windows compile errors, which eventually led me to clean up more of ...

7 years, 11 months ago (2013-01-09 05:50:59 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11783045/4004

7 years, 11 months ago (2013-01-09 22:27:18 UTC) #8

Message was sent while issue was closed.

Change committed as 175975

Expand Messages | Collapse Messages