Remove the SRPC IRT nexes from Chrome installers.

Remove the SRPC IRT nexes from Chrome installers.
The nexes are still built so we can run SRPC tests.
BUG=154443
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175904

[bbudge, 2013-01-08 19:17:13]

svn server is broken. I will re-try later.

[brettw, 2013-01-09 18:45:03]

lgtm

[commit-bot: I haz the power, 2013-01-09 18:55:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/11783036/1

[commit-bot: I haz the power, 2013-01-09 22:36:17]

Change committed as 175904

[Mark Seaborn, 2013-01-09 22:42:36]

Bill, could you file a new issue to track removing the old SRPC proxy?  I
imagine there will be a lot of cleanup changes and it would be useful having
them all listed in one place.

[Mark Seaborn, 2013-01-11 00:02:07]

> The nexes are still built so we can run SRPC tests.

I don't think that's true on Mac: the nexe is no longer included in the
Chromium.app image, so running the SRPC tests will fail.

I think this is causing most people's nacl_integration runs to fail on the
trybots.  e.g. Chosen at random,
http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/88320/...
contains many failures with:

[53584:-1255550976:0110/153040:ERROR:nacl_browser.cc(208)] Failed to open NaCl
IRT file
"/Volumes/data/b/build/slave/mac/build/src/out/Release/Chromium.app/Contents/Versions/26.0.1380.0/Chromium
Framework.framework/Internet Plug-Ins/nacl_irt_srpc_x86_32.nexe": -4

See http://build.chromium.org/p/tryserver.chromium/builders/mac_rel

I suspect this wasn't caught by your try runs because the incremental Mac build
doesn't delete the file from Chromium.app.

Can you either turn off the SRPC tests in nacl_integration (grep for
--enable-nacl-srpc-proxy in ppapi/native_client) or revert this change, please?

Mark

[jvoung - send to chromium..., 2013-01-15 22:17:33]

https://codereview.chromium.org/11783036/diff/1/chrome/tools/build/linux/FILE...
File chrome/tools/build/linux/FILES.cfg (left):

https://codereview.chromium.org/11783036/diff/1/chrome/tools/build/linux/FILE...
chrome/tools/build/linux/FILES.cfg:136: 'filename': 'nacl_irt_srpc_arm.nexe',
Just happened to notice this while looking through the file, did you want to
remove the arm srpc one too?

[bbudge, 2013-01-15 22:22:23]

https://codereview.chromium.org/11783036/diff/1/chrome/tools/build/linux/FILE...
File chrome/tools/build/linux/FILES.cfg (left):

https://codereview.chromium.org/11783036/diff/1/chrome/tools/build/linux/FILE...
chrome/tools/build/linux/FILES.cfg:136: 'filename': 'nacl_irt_srpc_arm.nexe',
On 2013/01/15 22:17:33, jvoung wrote:
> Just happened to notice this while looking through the file, did you want to
> remove the arm srpc one too?

Indeed. I'll create another issue. Ugh.