Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 11783032: ash: Fix abort-shutdown animation. (Closed)

Created:
7 years, 11 months ago by Daniel Erat
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Denis Kuznetsov (DE-MUC)
Visibility:
Public.

Description

ash: Fix abort-shutdown animation. This fixes a typo in SessionStateControllerImpl2 where the wrong duration was being used for the restore-brightness-and-grayscale animation displayed when the user releases the power button before holding it long enough to shut down (it was using 150 ms; this changes it to 500 ms). It also corrects a similar typo in the undo-move-windows animation (with no intended changes, though) and changes the tween type for the abort-shutdown animation to make it less flickery. BUG=168793 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M ash/wm/session_state_animator.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/session_state_controller_impl2.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Erat
7 years, 11 months ago (2013-01-08 17:32:57 UTC) #1
sky
LGTM
7 years, 11 months ago (2013-01-08 19:09:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11783032/1
7 years, 11 months ago (2013-01-08 19:14:41 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 19:17:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11783032/1
7 years, 11 months ago (2013-01-08 20:17:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-09 01:38:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/11783032/1
7 years, 11 months ago (2013-01-09 14:47:59 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 16:48:37 UTC) #8
Message was sent while issue was closed.
Change committed as 175814

Powered by Google App Engine
This is Rietveld 408576698