Restore the bytes promoted counter.

runtime/vm/scavenger.cc

Index: runtime/vm/scavenger.cc
diff --git a/runtime/vm/scavenger.cc b/runtime/vm/scavenger.cc
index f6273457278a9649199f5d958cdc28428cca6212..047c5fb0a54ccaff2b0c9840cdf83b61575cac0f 100644
--- a/runtime/vm/scavenger.cc
+++ b/runtime/vm/scavenger.cc
@@ -74,6 +74,7 @@ class ScavengerVisitor : public ObjectPointerVisitor {
         vm_heap_(Dart::vm_isolate()->heap()),
         delayed_weak_stack_(),
         growth_policy_(PageSpace::kControlGrowth),
+        bytes_promoted_(0),
         visiting_old_pointers_(false),
         in_scavenge_pointer_(false) {}
 
@@ -108,6 +109,8 @@ class ScavengerVisitor : public ObjectPointerVisitor {
     }
   }
 
+  intptr_t bytes_promoted() { return bytes_promoted_; }

[siva, 2013/01/07 22:35:33]

intptr_t bytes_promoted() const { ... }

[cshapiro, 2013/01/07 23:16:22]

I thought about doing this during my original change that added this value.

However, none of the other fields in the class make this distinction, so it
looks out of place.

I will add it to this change but it does not appear consistent with the rest of
this class.

+
  private:
   void UpdateStoreBuffer(RawObject** p, RawObject* obj) {
     uword ptr = reinterpret_cast<uword>(p);
@@ -184,6 +187,7 @@ class ScavengerVisitor : public ObjectPointerVisitor {
           // If promotion succeeded then we need to remember it so that it can
           // be traversed later.
           scavenger_->PushToPromotedStack(new_addr);
+          bytes_promoted_ += size;
           if (HeapTrace::is_enabled()) {
             heap_->trace()->TracePromotion(raw_addr, new_addr);
           }
@@ -196,6 +200,7 @@ class ScavengerVisitor : public ObjectPointerVisitor {
           new_addr = heap_->TryAllocate(size, Heap::kOld, growth_policy_);
           if (new_addr != 0) {
             scavenger_->PushToPromotedStack(new_addr);
+            bytes_promoted_ += size;
             if (HeapTrace::is_enabled()) {
               heap_->trace()->TracePromotion(raw_addr, new_addr);
             }
@@ -242,6 +247,7 @@ class ScavengerVisitor : public ObjectPointerVisitor {
   DelaySet delay_set_;
   GrowableArray<RawObject*> delayed_weak_stack_;
   PageSpace::GrowthPolicy growth_policy_;
+  intptr_t bytes_promoted_;

[siva, 2013/01/07 22:33:45]

Currently this variable is not being used anywhere in the code. Could you add a
comment here indicating how the field will be used.

[cshapiro, 2013/01/07 23:16:22]

I will add a TODO comment about this value's relationship to survival
statistics.

 
   bool visiting_old_pointers_;
   bool in_scavenge_pointer_;