Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 1178223003: [Document mode] Fix updateRecentlyClosed(). (Closed)

Created:
5 years, 6 months ago by gone
Modified:
5 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Document mode] Fix updateRecentlyClosed(). Code was copied over incorrectly. BUG=498871 Committed: https://crrev.com/0ab55eeedd58f3a61d951834a0e45614b18c914e Cr-Commit-Position: refs/heads/master@{#334034}

Patch Set 1 #

Patch Set 2 : Get rid of fallback. #

Patch Set 3 : #

Patch Set 4 : Extra null check for good measure #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
gone
5 years, 6 months ago (2015-06-11 19:19:33 UTC) #2
gone
Good to go, again.
5 years, 6 months ago (2015-06-11 19:29:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178223003/60001
5 years, 6 months ago (2015-06-11 19:29:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-11 20:03:18 UTC) #7
Ted C
lgtm
5 years, 6 months ago (2015-06-11 20:19:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178223003/80001
5 years, 6 months ago (2015-06-11 20:21:12 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-11 20:59:32 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 21:00:33 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0ab55eeedd58f3a61d951834a0e45614b18c914e
Cr-Commit-Position: refs/heads/master@{#334034}

Powered by Google App Engine
This is Rietveld 408576698