Issue 11782024: Remove unused methods from SpdyFrameBuilder.

Issue 11782024: Remove unused methods from SpdyFrameBuilder. (Closed)

Created:
7 years, 11 months ago by Ryan Hamilton

Modified:
7 years, 11 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused methods from SpdyFrameBuilder. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175705

Patch Set 2 : Fix comments #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -35 lines)			Patch
	M	net/spdy/spdy_frame_builder.h	View	1	5 chunks	+8 lines, -33 lines	0 comments	Download
	M	net/spdy/spdy_frame_builder.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

lgtm https://codereview.chromium.org/11782024/diff/1/net/spdy/spdy_frame_builder.h File net/spdy/spdy_frame_builder.h (left): https://codereview.chromium.org/11782024/diff/1/net/spdy/spdy_frame_builder.h#oldcode18 net/spdy/spdy_frame_builder.h:18: // This class provides facilities for basic binary ...

7 years, 11 months ago (2013-01-07 23:46:49 UTC) #2

Ryan Hamilton

https://codereview.chromium.org/11782024/diff/1/net/spdy/spdy_frame_builder.h File net/spdy/spdy_frame_builder.h (left): https://codereview.chromium.org/11782024/diff/1/net/spdy/spdy_frame_builder.h#oldcode18 net/spdy/spdy_frame_builder.h:18: // This class provides facilities for basic binary value ...

7 years, 11 months ago (2013-01-08 00:48:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/11782024/3

7 years, 11 months ago (2013-01-09 00:05:23 UTC) #4

Message was sent while issue was closed.

Change committed as 175705

Expand Messages | Collapse Messages