Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11782020: Refactor so chromium only GL extensions require gl2extchromium.h (Closed)

Created:
7 years, 11 months ago by greggman
Modified:
7 years, 11 months ago
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Refactor so chromium only GL extensions require gl2extchromium.h This is a step toward making third_party/khronos/gl2.h and gl2ext.h have as few modifications as possible. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175858

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M cc/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M cc/gl_renderer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/io_surface_layer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resource_provider.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M cc/resource_provider_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_web_graphics_context_3d.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/texture_uploader.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M cc/video_layer_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_c_lib.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_bind_uniform_location_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_chromium_framebuffer_multisample_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_lose_context_chromium_unittests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_query_unittests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_texture_mailbox_unittests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webkit/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/gpu/gl_bindings_skia_cmd_buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
greggman
Hey thakis, jamesr, apatrick, PTAL jamesr, PTAL at cc and webkit thakis, PTAL at content/browser/renderer_host ...
7 years, 11 months ago (2013-01-07 21:56:22 UTC) #1
jamesr
lgtm
7 years, 11 months ago (2013-01-07 21:59:14 UTC) #2
apatrick_chromium
lgtm
7 years, 11 months ago (2013-01-07 22:01:24 UTC) #3
Nico
lgtm
7 years, 11 months ago (2013-01-07 22:02:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11782020/1
7 years, 11 months ago (2013-01-07 22:18:24 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on linux_aura HTTP Error 400: Bad Request
7 years, 11 months ago (2013-01-07 22:38:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11782020/6002
7 years, 11 months ago (2013-01-07 22:40:29 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-07 23:19:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11782020/11003
7 years, 11 months ago (2013-01-07 23:51:27 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-08 00:20:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11782020/15004
7 years, 11 months ago (2013-01-08 00:45:10 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-08 01:25:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11782020/15004
7 years, 11 months ago (2013-01-08 01:41:19 UTC) #13
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-08 02:02:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11782020/37002
7 years, 11 months ago (2013-01-09 17:26:36 UTC) #15
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 19:56:42 UTC) #16
Message was sent while issue was closed. 
Change committed as 175858

Powered by Google App Engine
This is Rietveld 408576698