Issue 11782006: Set Virtual Me2Me desktop's initial DPI to 96

Issue 11782006: Set Virtual Me2Me desktop's initial DPI to 96 (Closed)

Created:
7 years, 11 months ago by Lambros

Modified:
7 years, 11 months ago

Reviewers:
Sergey Ulanov, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set Virtual Me2Me desktop's initial DPI to 96 BUG=168210 TEST=Before any client connects, "xdpyinfo -display :20|grep -A1 dimensions" shows ~96dpi. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175240

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add () #

Patch Set 3 : Use --dpi #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	remoting/tools/me2me_virtual_host.py	View	1 2	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Lambros

https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py#newcode332 remoting/tools/me2me_virtual_host.py:332: subprocess.call(args, env=self.child_env, stdout=devnull, stderr=devnull) call() takes same args as ...

7 years, 11 months ago (2013-01-04 22:21:36 UTC) #1

Sergey Ulanov

https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py#newcode352 remoting/tools/me2me_virtual_host.py:352: args = ["xrandr", "--fbmm", "%dx%d" % (width_mm, height_mm)] why ...

7 years, 11 months ago (2013-01-04 22:28:32 UTC) #2

Wez

lgtm https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py#newcode350 remoting/tools/me2me_virtual_host.py:350: width_mm = int(width / DPI * MM_PER_INCH) nit: ...

7 years, 11 months ago (2013-01-04 22:32:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/11782006/1002

7 years, 11 months ago (2013-01-04 23:10:18 UTC) #4

Wez

lgtm https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): https://codereview.chromium.org/11782006/diff/1/remoting/tools/me2me_virtual_host.py#newcode352 remoting/tools/me2me_virtual_host.py:352: args = ["xrandr", "--fbmm", "%dx%d" % (width_mm, height_mm)] ...

7 years, 11 months ago (2013-01-04 23:36:02 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/11782006/1004

7 years, 11 months ago (2013-01-04 23:42:11 UTC) #7

Message was sent while issue was closed.

Change committed as 175240

Expand Messages | Collapse Messages