Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: build/common.gypi

Issue 117803002: Make building seccomp-bpf a GYP condition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl.gyp » ('j') | components/nacl.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f07719c66ec0422a1a2f47cc4d77c24b5e0dff85..ae97babb6c8c3e681c93fcce46cadf0e302be2d3 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1916,6 +1916,16 @@
}],
],
}],
+ # seccomp-bpf is only supportd on three architectures currently.
Mark Seaborn 2013/12/18 08:10:21 Typo: "supported". Maybe say "seccomp-bpf sandbox
jln (very slow on Chromium) 2013/12/19 00:00:19 Done.
+ # Do not disable seccomp_bpf anywhere without talking to
+ # security@chromium.org!
+ ['((OS=="linux" or OS=="android") and '
+ '(target_arch=="ia32" or target_arch=="x64" or '
+ 'target_arch=="arm"))', {
+ 'use_seccomp_bpf%': 1,
+ }, {
+ 'use_seccomp_bpf%': 0,
+ }]
Mark Seaborn 2013/12/18 08:10:21 Nit: add trailing comma
jln (very slow on Chromium) 2013/12/19 00:00:19 Done.
],
# The path to the ANGLE library.
« no previous file with comments | « no previous file | components/nacl.gyp » ('j') | components/nacl.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698