Centralize keypress listener handling in non-platform-specific code.

Centralize keypress listener handling in non-platform-specific code.

This moves the GTK- and Views-specific code for alerting RenderWidgetHostView keypress listeners of keypress events into the shared method RenderWidgetHostImpl::ForwardKeyboardEvent() that all implementations bottleneck through.

Also updates RenderWidgetHostImpl::KeyPressListenersHandleEvent() to ignore events with the skip_in_browser flag set.

BUG=51644
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175691

[Ilya Sherman, 2013-01-08 02:11:05]

Evan, can you sanity-check this before I send it out to a content/ OWNER?  Is
there any reason you're aware of to keep the platform-specific implementations?

[Evan Stade, 2013-01-08 20:54:56]

seems fine

https://chromiumcodereview.appspot.com/11779035/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://chromiumcodereview.appspot.com/11779035/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:1036: if
(KeyPressListenersHandleEvent(key_event))
should this come after the ignore input events check? the ignore_input_events_
comment doesn't help me understand it.

[Ilya Sherman, 2013-01-08 21:01:45]

https://chromiumcodereview.appspot.com/11779035/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://chromiumcodereview.appspot.com/11779035/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_impl.cc:1036: if
(KeyPressListenersHandleEvent(key_event))
On 2013/01/08 20:54:56, Evan Stade wrote:
> should this come after the ignore input events check? the ignore_input_events_
> comment doesn't help me understand it.

Yeah, I wasn't sure either... but after some more digging, it looks like
ignore_input_events_ is set when there are modal dialogs up, so we should
probably continue to respect that.  Fixed.

[Ilya Sherman, 2013-01-08 21:02:59]

Scott, PTAL

[sky, 2013-01-08 21:32:40]

LGTM

[commit-bot: I haz the power, 2013-01-08 21:35:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/11779035/1005

[commit-bot: I haz the power, 2013-01-09 03:25:00]

Change committed as 175691