Remove unused images; change confirm (spelling) bubble close button.

Remove unused images; change confirm (spelling) bubble close button.

Remove IDR_INFO_BUBBLE_CLOSE and various unused/unreferenced PNGs.

Change the (x) close button image for ConfirmBubbleViews.
(the new image matches the new dialog style specification)
(the button currently doesn't use hover/pressed state images)
(see before/after pictures at http://crrev.com/166075#c6)

Note: To test the only use of ConfirmBubbleViews, open a webpage textfield context menu (right-click) and select "Spell-checker options" -> "Ask Google for suggestions". Observe the dialog's close button.

BUG=166075
TEST=Spelling bubble has better (x) image; no build breaks.
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175510

[msw, 2013-01-07 23:55:19]

Hey Scott, please take a look; thanks!

[tfarina, 2013-01-08 00:12:29]

2013/1/7  <msw@chromium.org>:
> Reviewers: sky,
>
> Message:
> Hey Scott, please take a look; thanks!
>
> Description:
> Nix unused images; change confirm (spelling) bubble close button.
>
Mike, "Nix" doesn't translate well to other languages, so for
non-native speakers it's hard to tell what nix means.

I know, because I remember you told what it means, time long time ago.

So, I'd just use "Remove" in places of "Nix".

> ConfirmBubbleViews IDR_INFO_BUBBLE_CLOSE->IDR_WEB_UI_CLOSE.

Can you write a sentence describing what you are doing here instead?

> (close to spec, no hover/pressed, see before/after at bug)
> (SpellingBubble: web textfield context -> "Spell..." -> "Ask"...)
Same here about sentence.

> Nix otherwise unused IDR_INFO_BUBBLE_CLOSE and unreferenced PNGs.
>
> BUG=166075
> TEST=Spelling bubble has better (x) image; no build breaks.
> R=sky@chromium.org
>

Thanks! ;)

> Please review this at https://codereview.chromium.org/11779030/
>

-- 
Thiago

[msw, 2013-01-08 00:25:55]

Sorry for the confusion Thiago, I updated the description.

Note that NotificationPromoTest is failing here (and for others on this
LKGR@175222) and was disabled in http://crrev.com/175332 I'll get some trybots
running on a newer revision.

[sky, 2013-01-08 04:47:52]

LGTM

[commit-bot: I haz the power, 2013-01-08 07:33:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/11779030/1

[commit-bot: I haz the power, 2013-01-08 10:09:26]

Change committed as 175510