Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 11779023: Aura: A little lighter GL synchronization (Closed)

Created:
7 years, 11 months ago by jonathan.backer
Modified:
7 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Aura: A little lighter GL synchronization On the consumeTextureCHROMIUM(), we only need to synchronize on the channel. This can be accomplished with a shallowFlushCHROMIUM() rather than a flush(), the latter which implies a service side glFlush(). BUG=none TEST=by hand Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175796

Patch Set 1 #

Patch Set 2 : Remove unnecessary BindAndApplyTextureParameters #

Patch Set 3 : Fix unittests #

Patch Set 4 : Bind the textures because client side expects it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -48 lines) Patch
M content/browser/renderer_host/image_transport_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_texture_mailbox.txt View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 chunks +2 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 2 chunks +2 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
jonathan.backer
I can't think of a reason for this to be a flush() instead of a ...
7 years, 11 months ago (2013-01-07 18:19:32 UTC) #1
piman
So, with the current code, we do some GL commands in the Consume handler (a ...
7 years, 11 months ago (2013-01-07 18:51:53 UTC) #2
jonathan.backer
On 2013/01/07 18:51:53, piman wrote: > So, with the current code, we do some GL ...
7 years, 11 months ago (2013-01-07 19:22:28 UTC) #3
piman
LGTM, thanks!
7 years, 11 months ago (2013-01-07 19:23:22 UTC) #4
jonathan.backer
Fixed the unittests. I'm not sure about the change to TextureManager::Save(...). It's consistent with the ...
7 years, 11 months ago (2013-01-07 22:28:38 UTC) #5
piman
On Mon, Jan 7, 2013 at 2:28 PM, <backer@chromium.org> wrote: > Fixed the unittests. I'm ...
7 years, 11 months ago (2013-01-07 22:47:46 UTC) #6
jonathan.backer
Think I got it this time :D Added the bind back because the client side ...
7 years, 11 months ago (2013-01-08 15:36:08 UTC) #7
piman
lgtm
7 years, 11 months ago (2013-01-08 17:54:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/11779023/16002
7 years, 11 months ago (2013-01-08 18:37:33 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:38:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/11779023/16002
7 years, 11 months ago (2013-01-08 19:51:46 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests
7 years, 11 months ago (2013-01-08 21:27:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/11779023/16002
7 years, 11 months ago (2013-01-08 22:30:58 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests
7 years, 11 months ago (2013-01-09 02:38:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/11779023/16002
7 years, 11 months ago (2013-01-09 13:06:26 UTC) #15
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 14:25:58 UTC) #16
Message was sent while issue was closed.
Change committed as 175796

Powered by Google App Engine
This is Rietveld 408576698