Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 11779019: browser: Move FindTabbedBrowser() function into chrome namespace. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, jeremya+watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

browser: Move FindTabbedBrowser() function into chrome namespace. BUG=133088 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175792

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -61 lines) Patch
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_finder.h View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
7 years, 11 months ago (2013-01-07 13:24:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11779019/1
7 years, 11 months ago (2013-01-09 11:44:14 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/extension_install_ui_default.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 11 months ago (2013-01-09 11:44:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11779019/8001
7 years, 11 months ago (2013-01-09 11:51:43 UTC) #4
commit-bot: I haz the power
Change committed as 175792
7 years, 11 months ago (2013-01-09 13:39:27 UTC) #5
Ben Goodger (Google)
7 years, 11 months ago (2013-01-09 17:16:13 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698