Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 11779010: Use a correct instance to create ITfContext. (Closed)

Created:
7 years, 11 months ago by Yohei Yukawa
Modified:
7 years, 11 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use a correct document manager to create an instance of ITfContext. Previous implementation always used |document_manager_for_editable_| to create an instance of ITfContext but it was incorrect. We should use corresponding document manager for each case. BUG=149136 TEST=Manually tested on Windows 8 with --enable-text-services-framework Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/ime/win/tsf_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Yohei Yukawa
7 years, 11 months ago (2013-01-05 13:29:10 UTC) #1
Seigo Nonaka
lgtm nit: /create create/create/ in patch description. lgtm, thank you for your catch up. BTW, ...
7 years, 11 months ago (2013-01-07 00:46:45 UTC) #2
Yohei Yukawa
On 2013/01/07 00:46:45, Seigo Nonaka wrote: > lgtm > > nit: /create create/create/ in patch ...
7 years, 11 months ago (2013-01-07 01:45:58 UTC) #3
Seigo Nonaka
lgtm
7 years, 11 months ago (2013-01-07 02:11:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/11779010/1
7 years, 11 months ago (2013-01-07 02:14:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 02:30:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/11779010/1
7 years, 11 months ago (2013-01-07 04:05:33 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 04:16:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/11779010/1
7 years, 11 months ago (2013-01-07 13:02:25 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 13:11:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/11779010/1
7 years, 11 months ago (2013-01-16 08:24:26 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 10:59:30 UTC) #12
Message was sent while issue was closed.
Change committed as 177129

Powered by Google App Engine
This is Rietveld 408576698