Fix metadata content size.

Fix metadata content size.

The previous implementation always returned zero since it checked the
bounds of the scroll layer instead of its child. Also add a unit test
for the metadata values.

BUG=161945
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175431

[aelias_OOO_until_Jul13, 2013-01-05 03:07:28]

Hi Dana, just a small fix for a bug in my metadata function.

[danakj, 2013-01-05 03:27:07]

https://codereview.chromium.org/11779008/diff/3003/cc/layer_tree_host_impl_un...
File cc/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/11779008/diff/3003/cc/layer_tree_host_impl_un...
cc/layer_tree_host_impl_unittest.cc:923: EXPECT_EQ(gfx::Vector2dF(0, 10),
metadata.root_scroll_offset);
the root scroll offset is getting scaled by the page scale factor. how cone its
not changing here?

https://codereview.chromium.org/11779008/diff/3003/cc/layer_tree_host_impl_un...
cc/layer_tree_host_impl_unittest.cc:933:
m_hostImpl->setPageScaleFactorAndLimits(2, 0.5f, 4);
can you use something other than 2 here so we know youre not just repeating the
above and that this call did something?

[aelias_OOO_until_Jul13, 2013-01-07 19:09:36]

https://codereview.chromium.org/11779008/diff/3003/cc/layer_tree_host_impl_un...
File cc/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/11779008/diff/3003/cc/layer_tree_host_impl_un...
cc/layer_tree_host_impl_unittest.cc:923: EXPECT_EQ(gfx::Vector2dF(0, 10),
metadata.root_scroll_offset);
On 2013/01/05 03:27:07, danakj wrote:
> the root scroll offset is getting scaled by the page scale factor. how cone
its
> not changing here?

In the new pinch zoom mode, the scroll offset is always in layer space and
unaffected by page scale changes.  In the old mode, I put an explicit division
by pageScaleFactor in makeCompositorFrameMetadata().

https://codereview.chromium.org/11779008/diff/3003/cc/layer_tree_host_impl_un...
cc/layer_tree_host_impl_unittest.cc:933:
m_hostImpl->setPageScaleFactorAndLimits(2, 0.5f, 4);
On 2013/01/05 03:27:07, danakj wrote:
> can you use something other than 2 here so we know youre not just repeating
the
> above and that this call did something?

OK, changed to 4.

[danakj, 2013-01-07 19:40:24]

Ah, okay. That if statement :) Thanks and LGTM

https://codereview.chromium.org/11779008/diff/5001/cc/layer_tree_host_impl_un...
File cc/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/11779008/diff/5001/cc/layer_tree_host_impl_un...
cc/layer_tree_host_impl_unittest.cc:894: EXPECT_EQ(gfx::Vector2dF(0, 0),
metadata.root_scroll_offset);
might as well style nit this now since we'll just have to fix it later. use
float suffix for any float literals. so Vector2dF() or Vector2dF(0.f, 0.f) or
Vector2dF(0.0f, 0.0f); Same for all the SizeF's below too.

[commit-bot: I haz the power, 2013-01-07 20:29:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aelias@chromium.org/11779008/10001

[commit-bot: I haz the power, 2013-01-07 22:31:40]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-07 22:40:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aelias@chromium.org/11779008/10001

[commit-bot: I haz the power, 2013-01-08 00:34:37]

Change committed as 175431