Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11778082: estade@ review feedback on r175674 (Closed)

Created:
7 years, 11 months ago by Dan Beam
Modified:
7 years, 11 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, sky
Visibility:
Public.

Description

estade@ review feedback on r175674, makes code prettier and less susceptible to use-after-free. R=estade@chromium.org BUG=166348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176425

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : brain fart #

Patch Set 4 : nit #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 3 chunks +13 lines, -12 lines 0 comments Download
M ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc View 1 2 3 3 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Evan Stade
i will be able to lgtm this when I am an owner.
7 years, 11 months ago (2013-01-10 02:46:05 UTC) #1
Dan Beam
+sky@ for OWNERS
7 years, 11 months ago (2013-01-10 04:12:24 UTC) #2
sky
Rubber stamp LGTM
7 years, 11 months ago (2013-01-10 16:33:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11778082/3001
7 years, 11 months ago (2013-01-10 19:35:46 UTC) #4
Evan Stade
https://chromiumcodereview.appspot.com/11778082/diff/3001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc File ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc (right): https://chromiumcodereview.appspot.com/11778082/diff/3001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc#newcode29 ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:29: gpointer data) { for some reason you didn't update ...
7 years, 11 months ago (2013-01-10 20:21:32 UTC) #5
Dan Beam
https://chromiumcodereview.appspot.com/11778082/diff/3001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc File ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc (right): https://chromiumcodereview.appspot.com/11778082/diff/3001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc#newcode29 ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:29: gpointer data) { On 2013/01/10 20:21:32, Evan Stade wrote: ...
7 years, 11 months ago (2013-01-11 00:09:00 UTC) #6
Dan Beam
https://chromiumcodereview.appspot.com/11778082/diff/3001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc File ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc (right): https://chromiumcodereview.appspot.com/11778082/diff/3001/ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc#newcode29 ui/base/dialogs/gtk/select_file_dialog_impl_gtk.cc:29: gpointer data) { On 2013/01/10 20:21:32, Evan Stade wrote: ...
7 years, 11 months ago (2013-01-11 00:09:00 UTC) #7
Evan Stade
lgtm
7 years, 11 months ago (2013-01-11 00:32:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11778082/11002
7 years, 11 months ago (2013-01-11 03:03:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11778082/11002
7 years, 11 months ago (2013-01-11 08:48:02 UTC) #10
commit-bot: I haz the power
Commit queue patch verification failed without an error message. Something went wrong, probably a crash, ...
7 years, 11 months ago (2013-01-11 10:12:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11778082/11002
7 years, 11 months ago (2013-01-11 18:18:38 UTC) #12
commit-bot: I haz the power
7 years, 11 months ago (2013-01-11 20:21:15 UTC) #13
Message was sent while issue was closed. 
Change committed as 176425

Powered by Google App Engine
This is Rietveld 408576698