Linux Sandbox: handle O_CREAT properly in broker process.

Linux Sandbox: handle O_CREAT properly in broker process.

We only support 2-parameters open in the broker process but we
didn't filter-out O_CREAT properly.

BUG=168944
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175744

[jln (very slow on Chromium), 2013-01-09 03:20:56]

PTAL

[Markus (顧孟勤), 2013-01-09 05:38:47]

lgtm

https://chromiumcodereview.appspot.com/11778056/diff/1/sandbox/linux/services...
File sandbox/linux/services/broker_process.cc (right):

https://chromiumcodereview.appspot.com/11778056/diff/1/sandbox/linux/services...
sandbox/linux/services/broker_process.cc:70: // We only support a 2-parameters
open, so we forbid O_CREAT.
We might have to support O_CREAT at some point. But I am fine with adding that
code when it is actually needed.

The way your CL looks like right now, that definitely keeps things simpler.

https://chromiumcodereview.appspot.com/11778056/diff/1/sandbox/linux/services...
sandbox/linux/services/broker_process.cc:85: O_APPEND | O_ASYNC | O_CLOEXEC |
O_CREAT | O_DIRECT |
I still feel that this code is confusing and hard to read. Listing O_CREAT in
this line makes it look to me, as if we expect to encounter O_CREAT at this
point.

But we had that argument before, and it's outside of the scope of this CL. So,
just FYI.

[commit-bot: I haz the power, 2013-01-09 05:39:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/11778056/1

[commit-bot: I haz the power, 2013-01-09 08:34:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/11778056/1

[commit-bot: I haz the power, 2013-01-09 08:34:55]

Change committed as 175744